copy address and back button fixes #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sajalbnl
commented
Dec 10, 2024
sajalbnl
commented
- issue [feat] Copy account address #132 [bug] Broken back buttons #131
- follows contribution guide
- code change includes tests
- breaking change
trbutler4
requested changes
Dec 12, 2024
wallet_app/local.properties
Outdated
| @@ -4,8 +4,8 @@ | |||
| # Location of the SDK. This is only used by Gradle. | |||
There was a problem hiding this comment.
please remove this from git and add to the .gitignore file. This is specific to your environment
| fontSize = 14.sp, | ||
| modifier = Modifier.align(Alignment.CenterHorizontally) | ||
| ) | ||
| Row( |
There was a problem hiding this comment.
can you center this with the text please
There was a problem hiding this comment.
also can you make the receive screen look and behave the same way?
| import androidx.compose.ui.res.painterResource | ||
| import androidx.compose.ui.text.font.Font | ||
| import androidx.compose.ui.text.font.FontFamily | ||
| import androidx.compose.ui.unit.dp | ||
| import androidx.compose.ui.unit.sp | ||
| import androidx.core.graphics.toColorInt | ||
| import com.example.walletapp.BuildConfig | ||
| import com.example.walletapp.R | ||
|
|
||
| @Composable | ||
| fun ReceiveScreen(modifier: Modifier) { |
There was a problem hiding this comment.
Please add a back button here as well.
| import androidx.compose.material3.DropdownMenu | ||
| import androidx.compose.material3.DropdownMenuItem | ||
| import androidx.compose.runtime.LaunchedEffect | ||
| import androidx.compose.runtime.collectAsState | ||
| import androidx.compose.runtime.remember |
There was a problem hiding this comment.
please add a back button to this screen as well
|
looks great thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.