Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test initiate_liquidity_withdraw #97

Conversation

chachaleo
Copy link
Contributor

Resolves: #86

bug :

The test : test_initiate_liquidity_withdraw_without_enough_liquidity

raises :

Failure data:
Incorrect panic data
Actual:    [0x556e6b6e6f776e20656e756d20696e64696361746f723a, 0x0] (Unknown enum indicator:, )
Expected:  [0x4e6f7420656e6f756768206c6971756964697479] (Not enough liquidity)

Portion of the code that panic : https://github.com/keep-starknet-strange/zkramp/blob/main/contracts/src/contracts/ramps/revolut/revolut.cairo#L268-L271

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zkramp-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2024 10:15am
zkramp-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2024 10:15am

Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.46%. Comparing base (bd4ff65) to head (5156498).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #97       +/-   ##
===========================================
+ Coverage   66.14%   78.46%   +12.31%     
===========================================
  Files          11       11               
  Lines         127      130        +3     
===========================================
+ Hits           84      102       +18     
+ Misses         43       28       -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chachaleo chachaleo marked this pull request as ready for review September 28, 2024 02:43
Copy link
Contributor

@0xChqrles 0xChqrles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !!

@0xChqrles 0xChqrles merged commit fa01485 into keep-starknet-strange:main Sep 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CONTRACTS] implement initiate_liquidity_withdraw tests
2 participants