fix(helm): database name as an environment variable #76

nlamirault · 2024-11-16T13:34:56Z

close #77

Signed-off-by: Nicolas Lamirault <[email protected]>

shahargl · 2024-11-16T13:48:26Z

hey @nlamirault, thanks for your contribution!

can I ask you to bump the version on Chart.yaml?

Signed-off-by: Nicolas Lamirault <[email protected]>

shahargl

can you please update the version too? to 0.1.41

Signed-off-by: Nicolas Lamirault <[email protected]>

shahargl

Hey @nlamirault - e2e tests are failing.

I think you need to change

command: ['sh', '-c', 'until nc -z ${DATABASE_NAME} 3306; do sleep 1; done;']

to

command: ['sh', '-c', 'until nc -z {{ include "keep.findEnvVar" (list "DATABASE_NAME" .) | default "keep-database" }} 3306; do sleep 1; done;']

shahargl

tests failing, need to change the env var to be from .Values

Signed-off-by: Nicolas Lamirault <[email protected]>

shahargl · 2024-11-21T11:28:31Z

hey @nlamirault , is it still an issue?

nlamirault · 2024-12-11T06:09:10Z

i've got this error now:

kubectl -n alerting logs keep-backend-7fbb7f8c44-mg72t
Defaulted container "keep" out of: keep, wait-for-database (init)
+ dirname /venv/lib/python3.11/site-packages/keep/entrypoint.sh
+ SCRIPT_DIR=/venv/lib/python3.11/site-packages/keep
+ exec gunicorn keep.api.api:get_app --bind 0.0.0.0:8080 --workers 4 -k uvicorn.workers.UvicornWorker -c /venv/lib/python3.11/site-packages/keep/api/config.py --preload
+ python /venv/lib/python3.11/site-packages/keep/server_jobs_bg.py
{"asctime": "2024-12-11 06:07:33,772", "message": "Starting background server jobs.", "levelname": "INFO", "name": "__main__", "filename": "server_jobs_bg.py", "otelTraceID": null, "otelSpanID": null, "otelServiceName": null, "threadName": "MainThread", "process": 8, "module": "server_jobs_bg"}
{"asctime": "2024-12-11 06:07:33,772", "message": "Checking if server is up at http://localhost:8080...", "levelname": "INFO", "name": "__main__", "filename": "server_jobs_bg.py", "otelTraceID": null, "otelSpanID": null, "otelServiceName": null, "threadName": "MainThread", "process": 8, "module": "server_jobs_bg"}
{"asctime": "2024-12-11 06:07:33,774", "message": "API is not up yet. Waiting...", "levelname": "INFO", "name": "__main__", "filename": "server_jobs_bg.py", "otelTraceID": null, "otelSpanID": null, "otelServiceName": null, "threadName": "MainThread", "process": 8, "module": "server_jobs_bg"}
{"asctime": "2024-12-11 06:07:34,855", "message": "Creating a connection pool with size 5", "levelname": "INFO", "name": "keep.api.core.db_utils", "filename": "db_utils.py", "otelTraceID": null, "otelSpanID": null, "otelServiceName": null, "threadName": "MainThread", "process": 1, "module": "db_utils"}
[2024-12-11 06:07:34 +0000] [1] [INFO] Starting gunicorn 22.0.0
{"asctime": "2024-12-11 06:07:34,874", "message": "Keep server starting", "levelname": "INFO", "name": "__config__", "filename": "config.py", "otelTraceID": null, "otelSpanID": null, "otelServiceName": null, "threadName": "MainThread", "process": 1, "module": "config"}
{"asctime": "2024-12-11 06:07:34,875", "message": "Running migrations...", "levelname": "INFO", "name": "keep.api.core.db_on_start", "filename": "db_on_start.py", "otelTraceID": null, "otelSpanID": null, "otelServiceName": null, "threadName": "MainThread", "process": 1, "module": "db_on_start"}
Traceback (most recent call last):
Traceback (most recent call last):
  File "/venv/lib/python3.11/site-packages/sqlalchemy/engine/base.py", line 3361, in _wrap_pool_connect
    return fn()
           ^^^^
  File "/venv/lib/python3.11/site-packages/sqlalchemy/pool/base.py", line 320, in connect
    return _ConnectionFairy._checkout(self)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/venv/lib/python3.11/site-packages/sqlalchemy/pool/base.py", line 884, in _checkout
    fairy = _ConnectionRecord.checkout(pool)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/venv/lib/python3.11/site-packages/sqlalchemy/pool/base.py", line 486, in checkout
    rec = pool._do_get()
          ^^^^^^^^^^^^^^
  File "/venv/lib/python3.11/site-packages/sqlalchemy/pool/impl.py", line 145, in _do_get
    with util.safe_reraise():
  File "/venv/lib/python3.11/site-packages/sqlalchemy/util/langhelpers.py", line 70, in __exit__
    compat.raise_(
  File "/venv/lib/python3.11/site-packages/sqlalchemy/util/compat.py", line 208, in raise_
    raise exception
  File "/venv/lib/python3.11/site-packages/sqlalchemy/pool/impl.py", line 143, in _do_get
    return self._create_connection()
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/venv/lib/python3.11/site-packages/sqlalchemy/pool/base.py", line 266, in _create_connection
    return _ConnectionRecord(self)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/venv/lib/python3.11/site-packages/sqlalchemy/pool/base.py", line 381, in __init__
    self.__connect()
  File "/venv/lib/python3.11/site-packages/sqlalchemy/pool/base.py", line 677, in __connect
    with util.safe_reraise():
  File "/venv/lib/python3.11/site-packages/sqlalchemy/util/langhelpers.py", line 70, in __exit__
    compat.raise_(
  File "/venv/lib/python3.11/site-packages/sqlalchemy/util/compat.py", line 208, in raise_
    raise exception
  File "/venv/lib/python3.11/site-packages/sqlalchemy/pool/base.py", line 673, in __connect
    self.dbapi_connection = connection = pool._invoke_creator(self)
                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/venv/lib/python3.11/site-packages/sqlalchemy/engine/create.py", line 578, in connect
    return dialect.connect(*cargs, **cparams)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/venv/lib/python3.11/site-packages/sqlalchemy/engine/default.py", line 598, in connect
    return self.dbapi.connect(*cargs, **cparams)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/venv/lib/python3.11/site-packages/pymysql/connections.py", line 361, in __init__
    self.connect()
  File "/venv/lib/python3.11/site-packages/pymysql/connections.py", line 669, in connect
    self._request_authentication()
  File "/venv/lib/python3.11/site-packages/pymysql/connections.py", line 957, in _request_authentication
    auth_packet = self._read_packet()
                  ^^^^^^^^^^^^^^^^^^^
  File "/venv/lib/python3.11/site-packages/pymysql/connections.py", line 775, in _read_packet
    packet.raise_for_error()
  File "/venv/lib/python3.11/site-packages/pymysql/protocol.py", line 219, in raise_for_error
    err.raise_mysql_exception(self._data)
  File "/venv/lib/python3.11/site-packages/pymysql/err.py", line 150, in raise_mysql_exception
    raise errorclass(errno, errval)
pymysql.err.OperationalError: (1524, "Plugin 'mysql_native_password' is not loaded")

using this environment variable in the deployment:

            - name: DATABASE_CONNECTION_STRING
              value: 'mysql+pymysql://keep:xxxxx@moco-keep-db-primary:3306/keep'

nlamirault · 2024-12-11T07:37:54Z

i change my Helm settings and use an external Postgres database, managed by the CloudNativePG Operator.
It works now.
but I made some changes in the deployment of the backend (and not use the backend manifest generated by the Helm chart)

- name: DATABASE_CONNECTION_STRING
   value: "postgresql://keep:xxxxxx@keep-rw:5432/keep"

and also:

initContainers:
        - command:
            - sh
            - '-c'
            - until nc -z keep-rw 5432; do sleep 1; done;

shahargl · 2024-12-11T07:48:50Z

@nlamirault

pymysql.err.OperationalError: (1524, "Plugin 'mysql_native_password' is not loaded")

this is because your MySQL server doesn't support password authentication - you should enable it for Keep to authenticate with user/password

shahargl · 2024-12-11T07:49:15Z

i change my Helm settings and use an external Postgres database, managed by the CloudNativePG Operator. It works now. but I made some changes in the deployment of the backend (and not use the backend manifest generated by the Helm chart)
- name: DATABASE_CONNECTION_STRING
   value: "postgresql://keep:xxxxxx@keep-rw:5432/keep"
and also:
initContainers:
        - command:
            - sh
            - '-c'
            - until nc -z keep-rw 5432; do sleep 1; done;

cool. would be happy to merge your changes to the helm repo if you want

Signed-off-by: Nicolas Lamirault <[email protected]>

fix(helm): database name

004636c

Signed-off-by: Nicolas Lamirault <[email protected]>

nlamirault requested a review from talboren as a code owner November 16, 2024 13:34

nlamirault added 2 commits November 16, 2024 18:34

feat(helm): bump chart version

a7dcaf1

Signed-off-by: Nicolas Lamirault <[email protected]>

Merge branch 'main' into fix/database-setup

af0837e

Signed-off-by: Nicolas Lamirault <[email protected]>

shahargl self-requested a review November 16, 2024 17:46

shahargl approved these changes Nov 16, 2024

View reviewed changes

shahargl self-requested a review November 16, 2024 17:46

nlamirault added 2 commits November 17, 2024 10:26

feat(helm): versions

f958f4e

Signed-off-by: Nicolas Lamirault <[email protected]>

feat(helm): app version

26a0263

Signed-off-by: Nicolas Lamirault <[email protected]>

shahargl approved these changes Nov 17, 2024

View reviewed changes

shahargl self-requested a review November 17, 2024 13:54

shahargl requested changes Nov 18, 2024

View reviewed changes

fix(helm): extract environment variable

ed92bd6

Signed-off-by: Nicolas Lamirault <[email protected]>

nlamirault and others added 3 commits November 21, 2024 18:11

Merge branch 'main' into fix/database-setup

cabc804

Merge branch 'main' into fix/database-setup

958cd1d

Merge branch 'main' into fix/database-setup

1ed19cd

nlamirault added 5 commits December 11, 2024 10:07

feat(helm): wait for database settings

a23df3d

Signed-off-by: Nicolas Lamirault <[email protected]>

feat(helm): documentation

c229e31

Signed-off-by: Nicolas Lamirault <[email protected]>

feat(helm): documentation

0c4b683

Signed-off-by: Nicolas Lamirault <[email protected]>

Merge branch 'main' into fix/database-setup

65224c8

Signed-off-by: Nicolas Lamirault <[email protected]>

Merge branch 'main' into fix/database-setup

b338a98

Signed-off-by: Nicolas Lamirault <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(helm): database name as an environment variable #76

fix(helm): database name as an environment variable #76

nlamirault commented Nov 16, 2024 •

edited by shahargl

Loading

shahargl commented Nov 16, 2024

shahargl left a comment •

edited

Loading

shahargl left a comment •

edited

Loading

shahargl left a comment

shahargl commented Nov 21, 2024

nlamirault commented Dec 11, 2024

nlamirault commented Dec 11, 2024

shahargl commented Dec 11, 2024

shahargl commented Dec 11, 2024

fix(helm): database name as an environment variable #76

Are you sure you want to change the base?

fix(helm): database name as an environment variable #76

Conversation

nlamirault commented Nov 16, 2024 • edited by shahargl Loading

shahargl commented Nov 16, 2024

shahargl left a comment • edited Loading

Choose a reason for hiding this comment

shahargl left a comment • edited Loading

Choose a reason for hiding this comment

shahargl left a comment

Choose a reason for hiding this comment

shahargl commented Nov 21, 2024

nlamirault commented Dec 11, 2024

nlamirault commented Dec 11, 2024

shahargl commented Dec 11, 2024

shahargl commented Dec 11, 2024

nlamirault commented Nov 16, 2024 •

edited by shahargl

Loading

shahargl left a comment •

edited

Loading

shahargl left a comment •

edited

Loading