Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): database name as an environment variable #76

Merged
merged 19 commits into from
Dec 28, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(helm): database name
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
  • Loading branch information
nlamirault committed Nov 16, 2024
commit 004636cb332c574c3c725106ea3b51262278d6e3
2 changes: 1 addition & 1 deletion charts/keep/templates/backend.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ spec:
{{- if .Values.backend.waitForDatabase }}
- name: wait-for-database
image: busybox
command: ['sh', '-c', 'until nc -z keep-database 3306; do sleep 1; done;']
command: ['sh', '-c', 'until nc -z ${DATABASE_NAME} 3306; do sleep 1; done;']
{{- end }}
{{- range .Values.backend.extraInitContainers }}
- name: {{ .name }}
Expand Down
2 changes: 2 additions & 0 deletions charts/keep/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ backend:
env:
- name: DATABASE_CONNECTION_STRING
value: mysql+pymysql://root@keep-database:3306/keep
- name: DATABASE_NAME
value: keep-database
- name: SECRET_MANAGER_TYPE
value: k8s
- name: PORT
Expand Down
Loading