Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dynamic ingress class name in annotations #117

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix: dynamic ingress class name in annotations #117

merged 1 commit into from
Jan 20, 2025

Conversation

zhenyatsk
Copy link
Contributor

@zhenyatsk zhenyatsk commented Jan 20, 2025 •
edited
Loading

Closes #107

📑 Description

Add actual class name instead of hardcoded one.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@zhenyatsk zhenyatsk requested a review from talboren as a code owner January 20, 2025 17:49
talboren
talboren approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@talboren talboren changed the title fix nginx ingress class name in annotations fix: dynamic ingress class name in annotations Jan 20, 2025
@talboren talboren enabled auto-merge (squash) January 20, 2025 17:53
@talboren talboren merged commit 1c71ffe into keephq:main Jan 20, 2025
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talboren talboren talboren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Non default ingress class name
2 participants
@zhenyatsk @talboren