Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update PUSHER_HOST from default values #13

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

pehlicd
Copy link
Contributor

@pehlicd pehlicd commented Mar 12, 2024

Closes #11

📑 Description

updated default value of the PUSHER_HOST env var and removed unused ingress definition.

@pehlicd pehlicd requested a review from talboren as a code owner March 12, 2024 11:39
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@talboren
Copy link
Member

@pehlicd any idea why tests are failing? I can push that in but just in case

@talboren talboren mentioned this pull request Mar 12, 2024
3 tasks
@pehlicd
Copy link
Contributor Author

pehlicd commented Mar 12, 2024

@pehlicd any idea why tests are failing? I can push that in but just in case

lint-chart fail, should be resolved with #9
test-chart, I will look into that but we can merge it

@talboren talboren merged commit 3dfee5a into keephq:main Mar 12, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Helm chart missing websocket ingress template
2 participants