Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hpa and variables #50

Merged
merged 6 commits into from
Oct 9, 2024
Merged

fix: hpa and variables #50

merged 6 commits into from
Oct 9, 2024

Conversation

mfroembgen
Copy link
Contributor

@mfroembgen mfroembgen commented Oct 9, 2024 •
edited
Loading

Closes #49

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@mfroembgen mfroembgen requested a review from talboren as a code owner October 9, 2024 06:37
@mfroembgen mfroembgen changed the title bug: fix hpa and variables fix: fix hpa and variables Oct 9, 2024
@mfroembgen mfroembgen changed the title fix: fix hpa and variables fix: hpa and variables Oct 9, 2024
talboren
talboren approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahargl wdyt?

shahargl
shahargl reviewed Oct 9, 2024
View reviewed changes
charts/keep/README.md Outdated Show resolved Hide resolved
@mfroembgen
Copy link
Contributor Author

@shahargl Please check again :)

@shahargl shahargl merged commit 57190a8 into keephq:main Oct 9, 2024
4 checks passed
@shahargl
Copy link
Member

shahargl commented Oct 9, 2024

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahargl shahargl shahargl left review comments

@talboren talboren talboren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Fix hpa and file name consistency
3 participants
@mfroembgen @shahargl @talboren