fix: fix

keephq · Dec 12, 2024 · 31ee8cd · 31ee8cd
1 parent 142a705
commit 31ee8cd
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/keep/api/alert_deduplicator/alert_deduplicator.py b/keep/api/alert_deduplicator/alert_deduplicator.py
@@ -102,6 +102,7 @@ def _apply_deduplication_rule(
                     "alert_id": alert.id,
                     "fingerprint": alert.fingerprint,
                     "tenant_id": self.tenant_id,
+                    "last_alert_hash_by_fingerprint": last_alert_hash_by_fingerprint,
                 },
             )
 

diff --git a/keep/api/core/db.py b/keep/api/core/db.py
@@ -2110,7 +2110,7 @@ def get_all_deduplication_stats(tenant_id):
     return stats
 
 
-def get_last_alert_hash_by_fingerprint(tenant_id, fingerprint):
+def get_last_alert_hash_by_fingerprint(tenant_id, fingerprint) -> str | None:
     # get the last alert for a given fingerprint
     # to check deduplication
     with Session(engine) as session:
@@ -2121,7 +2121,7 @@ def get_last_alert_hash_by_fingerprint(tenant_id, fingerprint):
             .limit(1)
         )
 
-        alert_hash = session.exec(query).first()
+        alert_hash: str | None = session.scalars(query).first()
     return alert_hash
 
 

diff --git a/tests/test_deduplications.py b/tests/test_deduplications.py
@@ -276,7 +276,6 @@ def test_custom_deduplication_rule(db_session, client, test_app):
     assert custom_rule_found
 
 
-@pytest.mark.timeout(20)
 @pytest.mark.parametrize(
     "test_app",
     [
@@ -321,6 +320,7 @@ def test_custom_deduplication_rule_behaviour(db_session, client, test_app):
         client.post(
             "/alerts/event/datadog", json=alert, headers={"x-api-key": "some-api-key"}
         )
+        time.sleep(0.3)
 
     deduplication_rules = client.get(
         "/deduplications", headers={"x-api-key": "some-api-key"}