fix(migrations): db's other than sqlite (#2276)

keephq · Oct 23, 2024 · 335e843 · 335e843
1 parent 124550e
commit 335e843
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 11 deletions.
diff --git a/keep/api/models/db/migrations/versions/2024-10-22-10-38_8438f041ee0e.py b/keep/api/models/db/migrations/versions/2024-10-22-10-38_8438f041ee0e.py
@@ -39,16 +39,23 @@ def upgrade() -> None:
         with op.batch_alter_table("provider", schema=None) as batch_op:
             batch_op.alter_column("pulling_enabled", nullable=False)
     else:
-        # Implementation for other databases
-        with op.batch_alter_table("provider", schema=None) as batch_op:
-            batch_op.add_column(
-                sa.Column(
-                    "pulling_enabled",
-                    sa.Boolean(),
-                    nullable=False,
-                    server_default=sa.true(),
-                )
-            )
+        # PostgreSQL and other databases implementation
+        # 1. Add the column as nullable
+        op.add_column(
+            "provider", sa.Column("pulling_enabled", sa.Boolean(), nullable=True)
+        )
+        # 2. Set default value for existing rows
+        op.execute(
+            "UPDATE provider SET pulling_enabled = true WHERE pulling_enabled IS NULL"
+        )
+        # 3. Make it non-nullable with default
+        op.alter_column(
+            "provider",
+            "pulling_enabled",
+            existing_type=sa.Boolean(),
+            nullable=False,
+            server_default=sa.true(),
+        )
 
 
 def downgrade() -> None:

diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "keep"
-version = "0.27.2"
+version = "0.27.3"
 description = "Alerting. for developers, by developers."
 authors = ["Keep Alerting LTD"]
 readme = "README.md"