fix: Better Demo Alerts

keephq · Nov 24, 2024 · 9acee70 · 9acee70
1 parent ea748d0
commit 9acee70
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 2 deletions.
diff --git a/keep/api/core/demo_mode.py b/keep/api/core/demo_mode.py
@@ -29,7 +29,7 @@
     {
         "sqlQuery": {"sql": "((name like :name_1))", "params": {"name_1": "%mq%"}},
         "groupDescription": "This rule groups all alerts related to MQ.",
-        "ruleName": "Message Queue Buckle Up",
+        "ruleName": "Message queue is getting filled up",
         "celQuery": '(name.contains("mq"))',
         "timeframeInSeconds": 86400,
         "timeUnit": "hours",
@@ -243,6 +243,14 @@ def get_or_create_topology(keep_api_key, keep_api_url):
                     if service["name"] == existing_service["display_name"]:
                         service["id"] = existing_service["id"]
 
+            # Check if any service does not have an id
+            for service in application_to_create["services"]:
+                if "id" not in service:
+                    logger.error(
+                        f"Service {service['name']} does not have an id. Application creation failed."
+                    )
+                    return True
+
             response = requests.post(
                 f"{keep_api_url}/topology/applications",
                 headers={"x-api-key": keep_api_key},

diff --git a/keep/providers/datadog_provider/alerts_mock.py b/keep/providers/datadog_provider/alerts_mock.py
@@ -35,4 +35,22 @@
             "priority": ["P1", "P3", "P4"],
         },
     },
+    "mq_consumer_struggling": {
+        "payload": {
+            "title": "mq consumer is struggling",
+            "type": "metric alert",
+            "query": "avg(last_1h):min:mq_processing{*} by {host} < 10",
+            "message": "MQ Consumer is processing less than 10 messages per second on {{host.name}}.",
+            "tags": "environment:production,team:database",
+            "priority": 4,
+            "monitor_id": "1234567891",
+        },
+        "parameters": {
+            "tags": [
+                "environment:production,team:analytics,monitor,service:api",
+                "environment:staging,team:database,monitor,service:api",
+            ],
+            "priority": ["P1", "P3", "P4"],
+        },
+    },
 }
diff --git a/keep/providers/prometheus_provider/alerts_mock.py b/keep/providers/prometheus_provider/alerts_mock.py
@@ -15,7 +15,7 @@
             "labels.instance": ["instance1", "instance2", "instance3"],
         },
     },
-    "mq_third_full": {
+    "mq_third_full (Message queue is over 33%)": {
         "payload": {
             "summary": "Message queue is over 33% capacity",
             "labels": {
@@ -29,6 +29,20 @@
             "labels.mq_manager": ["mq_manager1", "mq_manager2", "mq_manager3"],
         },
     },
+    "mq_full (Message queue is full)": {
+        "payload": {
+            "summary": "Message queue is over 90% capacity",
+            "labels": {
+                "severity": "critical",
+                "customer_id": "acme"
+            },
+        },
+        "parameters": {
+            "labels.queue": ["queue4"],
+            "labels.service": ["calendar-producer-java-otel-api-dd", "kafka", "queue"],
+            "labels.mq_manager": ["mq_manager4"],
+        },
+    },
     "disk_space_low": {
         "payload": {
             "summary": "Disk space is below 20%",