Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🔨 Enhancement]: Clicking "Save" on step doesn't save the changes on the server (only on deploy) #1937

Closed
shahargl opened this issue Sep 16, 2024 · 11 comments · Fixed by #1938

Comments

@shahargl
Copy link
Member

  1. Clicking "Save" should actually save the workflow (maybe change and save & deploy)
@shahargl
Copy link
Member Author

CleanShot 2024-09-16 at 10 39 47@2x

@shahargl
Copy link
Member Author

/bounty 25

Copy link

algora-pbc bot commented Sep 16, 2024

💎 $25 bounty • Keep (YC W23)

Steps to solve:

  1. Start working: Comment /attempt #1937 with your implementation plan
  2. Submit work: Create a pull request including /claim #1937 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to keephq/keep!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @rajeshj11 Sep 16, 2024, 7:41:53 AM #1938

@rajesh-jonnalagadda
Copy link
Contributor

@shahargl I would like to work on it

@rajesh-jonnalagadda
Copy link
Contributor

rajesh-jonnalagadda commented Sep 16, 2024

/attempt #1937

Algora profile Completed bounties Tech Active attempts Options
@rajeshj11    3 keephq bounties
+ 16 bounties from 7 projects
JavaScript, TypeScript,
HTML
Cancel attempt

@rajesh-jonnalagadda
Copy link
Contributor

@shahargl can i get assigned?

@shahargl
Copy link
Member Author

@rajeshj11 assigned

@rajesh-jonnalagadda
Copy link
Contributor

@shahargl In save & deploy functionality.

  1. deployment happens only if the workflow does not have any errors.
  2. If no errors on clicking save & deploy. It should save the step and deploy automatically.

Please confirm

@shahargl
Copy link
Member Author

@rajeshj11 I'm not sure whats the difference is between 1 and 2, but I'll answer generally:
when the user clicks on "save and deploy":

  1. if there is an error that is validated on the frontend - show an indicative error message
  2. o/w, it should save (like today, locally) and then deploy (send PUT to the server like clicking on deploy button)

Copy link

algora-pbc bot commented Sep 16, 2024

💡 @rajeshj11 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

@talboren talboren changed the title [🐛 Bug]: Clicking "Save" on step doesn't save the changes on the server (only on deploy) [🔨 Enhancement]: Clicking "Save" on step doesn't save the changes on the server (only on deploy) Sep 16, 2024
Copy link

algora-pbc bot commented Sep 24, 2024

🎉🎈 @rajeshj11 has been awarded $25! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants