Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save and deploy change #1938

Merged
merged 11 commits into from
Sep 19, 2024

Conversation

rajesh-jonnalagadda
Copy link
Contributor

@rajesh-jonnalagadda rajesh-jonnalagadda commented Sep 16, 2024

Closes #1937
/claim #1937

πŸ“‘ Description

we need to save and deploy

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Copy link

vercel bot commented Sep 16, 2024

@rajeshj11 is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@rajesh-jonnalagadda
Copy link
Contributor Author

@shahargl please review

Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Sep 16, 2024 4:06pm

@talboren
Copy link
Member

@shahargl @rajeshj11 is this ready to be merged?

@rajesh-jonnalagadda
Copy link
Contributor Author

rajesh-jonnalagadda commented Sep 16, 2024

@talboren waiting for review/feedback

@rajesh-jonnalagadda
Copy link
Contributor Author

@talboren waiting for review/feedback

@talboren ^^

@shahargl shahargl self-requested a review September 19, 2024 07:59
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shahargl shahargl merged commit 6f2ee05 into keephq:main Sep 19, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[πŸ”¨ Enhancement]: Clicking "Save" on step doesn't save the changes on the server (only on deploy)
3 participants