fix: background execution #1433

Matvey-Kuk · 2024-07-21T17:47:44Z

Signed-off-by: Tal <[email protected]> Co-authored-by: Tal <[email protected]>

Signed-off-by: Matvey Kukuy <[email protected]>

codecov · 2024-08-11T14:07:07Z

Codecov Report

Attention: Patch coverage is 40.77670% with 61 lines in your changes missing coverage. Please review.

Project coverage is 68.34%. Comparing base (c0be6a5) to head (373d560).
Report is 45 commits behind head on main.

Files	Patch %	Lines
keep/api/core/db.py	21.95%	32 Missing ⚠️
keep/api/tasks/process_background_ai_task.py	31.03%	20 Missing ⚠️
keep/api/utils/import_ee.py	66.66%	4 Missing ⚠️
keep/api/routes/incidents.py	50.00%	3 Missing ⚠️
keep/api/routes/alerts.py	0.00%	1 Missing ⚠️
keep/api/tasks/process_event_task.py	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1433      +/-   ##
==========================================
- Coverage   68.38%   68.34%   -0.05%     
==========================================
  Files         112      122      +10     
  Lines        9288     9858     +570     
==========================================
+ Hits         6352     6737     +385     
- Misses       2936     3121     +185

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

keep/api/models/db/migrations/versions/2024-08-09-10-53_6e353161f5a8.py

keep/api/models/db/migrations/versions/2024-07-24-13-39_9ba0aeecd4d0.py

talboren

Lots of comments, I'm sorry ❤️

P.S. I probably have a few more and will add them later on.

General comment I discussed with @GlebBerjoskin: AI summarization for incidents should also be available for non AI generated incidents. (i.e., human generated and manually correlated incidents)

ee/experimental/graph_utils.py

keep-ui/app/ai/ai.tsx

keep/api/core/db.py

keep/api/tasks/process_event_task.py

keep/api/utils/import_ee.py

Co-authored-by: Tal <[email protected]> Signed-off-by: Matvey Kukuy <[email protected]>

…rameters-and-background-execution' into Matvey-Kuk/hyper-parameters-and-background-execution

…xecution

Co-authored-by: Tal <[email protected]> Signed-off-by: Matvey Kukuy <[email protected]>

…rameters-and-background-execution' into Matvey-Kuk/hyper-parameters-and-background-execution

…xecution

…th fixed fields

…xecution

…xecution Signed-off-by: Matvey Kukuy <[email protected]>

VladimirFilonov

LGTM

Addressed by Gleb

GlebBerjoskin and others added 30 commits July 10, 2024 18:42

adding incidents to models

bbdffc6

fix: gcp monitoring (#1340)

7fb843f

Signed-off-by: Tal <[email protected]> Co-authored-by: Tal <[email protected]>

fix: mapping (#1341)

daf4ecb

fix: rules (#1343)

bda46f8

fix(api): jwks cache user agent (#1342)

ec53e89

fix: disposable enrichments (#1339)

3c215db

fix: gcp (#1344)

73b38e9

fix(api): remove async from process event since it's not async (#1346)

1bf2eda

adding incidents to models

7021fce

hardcoded incident assignment updated

afd87b7

simple alert clustering algorithm added

6d05887

Implement simple data model and CRUD API for incidents

adc1321

lp-for-ai

36724d9

Icon

7032820

Merge branch 'feature/incidents' into Matvey-Kuk/ai-ui-lp

360f8d0

adding incidents to models

af89d94

Implement simple data model and CRUD API for incidents

d7d677c

Basic CRUD UI for Incidents

0bd443d

Add methods and routes to add/remove alerts to the incident

606b068

Merge remote-tracking branch 'upstream/feature/incidents'

e15284a

feat: Merge branch 'main' into feature/incidents

0966130

Simple page

c7cdaf2

Merge branch 'feature/incidents' into Matvey-Kuk/ai-ui-lp

b25a050

Signed-off-by: Matvey Kukuy <[email protected]>

Fix issue with getting incident's alerts

310bab6

Delete alerts-to-incidents relations on deleting incidents

a49971d

Polishing

a69d284

WIP: AI UI lp for incidents (#1379)

b0687a5

Add simple UI for alerts-to-incidents association

f72d66c

Removed dal module and move all functions to db.py

b999678

License moves

bddaab5

summarization has been updated

5d15b3d

shahargl reviewed Aug 11, 2024

View reviewed changes

keep/api/models/db/migrations/versions/2024-08-09-10-53_6e353161f5a8.py Show resolved Hide resolved

shahargl reviewed Aug 11, 2024

View reviewed changes

keep/api/models/db/migrations/versions/2024-07-24-13-39_9ba0aeecd4d0.py Show resolved Hide resolved

talboren previously requested changes Aug 11, 2024

View reviewed changes

Matvey-Kuk and others added 7 commits August 11, 2024 18:55

Update ee/experimental/incident_utils.py

69a6f34

Co-authored-by: Tal <[email protected]> Signed-off-by: Matvey Kukuy <[email protected]>

Running separate tasks for specific tenants without duplicates

9dcfe3a

Merge remote-tracking branch 'refs/remotes/origin/Matvey-Kuk/hyper-pa…

5c3308d

…rameters-and-background-execution' into Matvey-Kuk/hyper-parameters-and-background-execution

Merge branch 'main' into Matvey-Kuk/hyper-parameters-and-background-e…

9fddb92

…xecution

Update ee/experimental/incident_utils.py

916566a

Co-authored-by: Tal <[email protected]> Signed-off-by: Matvey Kukuy <[email protected]>

Addressing PR review comments

2e97ff3

Merge remote-tracking branch 'refs/remotes/origin/Matvey-Kuk/hyper-pa…

0eb15ee

…rameters-and-background-execution' into Matvey-Kuk/hyper-parameters-and-background-execution

vercel bot deployed to Preview August 11, 2024 16:33 View deployment

Matvey-Kuk and others added 12 commits August 11, 2024 19:45

merge migration

54a62a5

Over-complicated imports so noone will ever be able to debug this

baae7b0

Merge branch 'main' into Matvey-Kuk/hyper-parameters-and-background-e…

fb4d1ea

…xecution

Removing hack to bypass faulty migration

89063a4

Fix tests

b373801

Make migrations even more isolated - create virtual copy of tables wi…

dfe3086

…th fixed fields

Remove unused imports

cd84a9b

Remove more unused imports

da887a8

Merge branch 'main' into Matvey-Kuk/hyper-parameters-and-background-e…

1f9143f

…xecution

Merge branch 'main' into Matvey-Kuk/hyper-parameters-and-background-e…

373d560

…xecution Signed-off-by: Matvey Kukuy <[email protected]>

minor fixes

134cbc5

minor fixes

df2c739

VladimirFilonov approved these changes Aug 13, 2024

View reviewed changes

Matvey-Kuk enabled auto-merge (squash) August 13, 2024 10:50

Matvey-Kuk merged commit e0e15cc into main Aug 13, 2024
10 checks passed

Matvey-Kuk deleted the Matvey-Kuk/hyper-parameters-and-background-execution branch August 13, 2024 10:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: background execution #1433

fix: background execution #1433

Matvey-Kuk commented Jul 21, 2024 •

edited

Loading

codecov bot commented Aug 11, 2024 •

edited

Loading

talboren left a comment

VladimirFilonov left a comment

fix: background execution #1433

fix: background execution #1433

Conversation

Matvey-Kuk commented Jul 21, 2024 • edited Loading

codecov bot commented Aug 11, 2024 • edited Loading

Codecov Report

talboren left a comment

Choose a reason for hiding this comment

VladimirFilonov left a comment

Choose a reason for hiding this comment

Matvey-Kuk commented Jul 21, 2024 •

edited

Loading

codecov bot commented Aug 11, 2024 •

edited

Loading