Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Refactoring workflow builder to use React Flow #1488

Merged
merged 124 commits into from
Sep 1, 2024
Merged

feat: Refactoring workflow builder to use React Flow #1488

merged 124 commits into from
Sep 1, 2024

Conversation

Bhavyajain21
Copy link
Contributor

Closes #1451

@vercel Vercel
Copy link

vercel bot commented Jul 29, 2024

@Bhavyajain21 is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Jul 29, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Bhavyajain21 Bhavyajain21 marked this pull request as ready for review July 29, 2024 16:51
@Bhavyajain21 Bhavyajain21 marked this pull request as draft July 29, 2024 16:51
@Bhavyajain21 Bhavyajain21 changed the title Feat/workflow enhance feat: Refactoring workflow builder to use React Flow Jul 29, 2024
rajesh-jonnalagadda and others added 22 commits July 31, 2024 18:38
@rajesh-jonnalagadda
refactor:use store to isolatet the operations for workflow flow build…
364a656 
…er and minor refactoring
@talboren
Merge branch 'main' into feat/workflow-enhance
3101734
@Bhavyajain21
Merge branch 'main' into feat/workflow-enhance
f0e4b0a
@rajesh-jonnalagadda
refactor:usiign store for handling the basic operation like add dupli…
6054f8a 
…cate,seletion and added toolbox and etting on the flow
@rajesh-jonnalagadda
chore:clean up
6ed993e
@Bhavyajain21
Merge pull request #2 from rajeshj11/basic-react-worflow-temp
7ec193f 
Basic react worflow temp
@rajesh-jonnalagadda
feat:added connection restrictions and code clean up
c939763
@rajesh-jonnalagadda
Merge pull request #3 from rajeshj11/basic-react-worflow-temp
9c1e528 
feat:added connection restrictions and code clean up
@Bhavyajain21
Merge branch 'keephq:main' into feat/workflow-enhance
8cde382
@Bhavyajain21
Initial UI changes
53e86ac
@rajesh-jonnalagadda
Merge pull request #4 from Bhavyajain21/feat/ui-hanges
21d4478 
Initial UI changes
@rajesh-jonnalagadda
feat: add non draggable functionality to the node.
c50ec95
@rajesh-jonnalagadda
refactor:using elkks to layout the workflow and also added auto appen…
84ceed2 
…ding and auto connection to source node on deletion and refactor of useworkflowinitialising
@rajesh-jonnalagadda
Merge remote-tracking branch 'jain-main/main' into feat-1451-dev-work…
6330111 
…flow-enhance
@rajesh-jonnalagadda
chore:refactored the flow layout structure and adjusted the toolbox a…
b9dac68 
…nd some minor chores
@rajesh-jonnalagadda
Merge pull request #5 from rajeshj11/feat-1451-dev-workflow-enhance
fc14618 
feat: add non draggable functionality to the node.
@Bhavyajain21
Merge branch 'main' into feat/workflow-enhance
fbbc1a1
@Bhavyajain21
Merge branch 'main' into feat/workflow-enhance
a9f7948
@Bhavyajain21
Merge branch 'main' into feat/workflow-enhance
a6df7d2
@Bhavyajain21
Merge branch 'main' into feat/workflow-enhance
d4710fa
@rajesh-jonnalagadda
feat:delete foreach switch anad added the builde statu tracker
8410ebc
@Bhavyajain21
Merge pull request #6 from rajeshj11/feat-1451-dev-workflow-enhance
7198e23 
feat:delete foreach switch anad added the builde statu tracker
@talboren
Copy link
Member

@Bhavyajain21 @rajeshj11 please note that tests are failing :(

@rajesh-jonnalagadda
Copy link
Contributor

@Bhavyajain21 @rajeshj11 please note that tests are failing :(

on it

@rajesh-jonnalagadda
Copy link
Contributor

@Bhavyajain21 @rajeshj11 please note that tests are failing :(

now tests are passed. please check

@talboren
Copy link
Member

talboren commented Sep 1, 2024

A few comments:
Save button is redundant, it made me not understand what's wrong with the workflow until I clicked on it.
Triggers:
We need validation for workflow saying "No triggers were configured, please configure at least 1 trigger"
If I add manual trigger, there is not reason to check the box
We need to add some divider for the configuration part
If trigger was added, if should be removed from the toolbox (e,.g., it's confusing that I still have manual when it's already in the workflow and I can't do anything with it)
Instead of "Trigger end" change to "Workflow start"

image
image
image

@talboren talboren mentioned this pull request Sep 1, 2024
Merged
@talboren talboren self-requested a review September 1, 2024 15:35
talboren
talboren approved these changes Sep 1, 2024
View reviewed changes
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@talboren talboren merged commit 8a8d554 into keephq:main Sep 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talboren talboren talboren approved these changes

Assignees

@talboren talboren

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🔨 Enhancement]: Refactoring workflow builder to use React Flow
6 participants
@Bhavyajain21 @CLAassistant @shahargl @talboren @rajesh-jonnalagadda @Matvey-Kuk