-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Optimize UI for smaller screens (#1220) #1491
fix: Optimize UI for smaller screens (#1220) #1491
Conversation
@Kiryous is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@Kiryous it seems like for some reason there is some E2E test failing due to the changes introduced in this branch. Can you please see if you can fix it? |
@talboren hey! yeah, I noticed it, but it seems bug in tests rather than bug in code, since I could see the provider's card in headful mode. But maybe I'm wrong. I'm out on vacation till August 23, and could look into it on return. |
Signed-off-by: Matvey Kukuy <[email protected]>
@Kiryous we're kinda blocked from merging this while it's breaking tests anyway :( |
@Kiryous @Matvey-Kuk I'm closing this PR for now as it is stale and we can re-open it once @Kiryous is able to fix the small issue here. 🙏🏼 |
Pull request was closed
…-optimize-ui-for-smaller-screens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@talboren thanks for reviewing and approving. Do not merge yet, please, wanna make a few minor additions |
PR author would like to add a few more minor changes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1491 +/- ##
==========================================
- Coverage 30.68% 30.66% -0.02%
==========================================
Files 54 54
Lines 5028 5031 +3
==========================================
Hits 1543 1543
- Misses 3485 3488 +3 ☔ View full report in Codecov by Sentry. |
Head branch was pushed to by a user without write access
@talboren added a fix so tiles of linked providers won't jump on hover. good to go! |
@Matvey-Kuk it seems the merging is blocked because the Vercel deployment is need authorization. Could you please authorize it? |
@Kiryous congrats and thank you for the contribution! <3 |
Closes #1220
📑 Description
Fix overflow, padding, and other issues that occur on smaller screens (<1280 px):
page-container
andcard-container
classes were introduced to unify the paddingsmin-w-0
added to places where the overflow of flex container happenedKnown issues:
✅ Checks
ℹ Additional Information
Watch Loom with comparison