Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when preset is private it needs to filtered form the asset links #1526

Merged

Conversation

rajesh-jonnalagadda
Copy link
Contributor

@rajesh-jonnalagadda rajesh-jonnalagadda commented Aug 3, 2024

/claim #1163

Closes #1163

📑 Description

If there is a private preset. we will check preset-created_by. if it matches the current session user then we will allow the preset on the UI or else we will ignore it.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Copy link

vercel bot commented Aug 3, 2024

@rajeshj11 is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@rajesh-jonnalagadda
Copy link
Contributor Author

@talboren please review

Copy link

vercel bot commented Aug 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Aug 4, 2024 7:31am

@talboren talboren self-requested a review August 4, 2024 07:39
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@talboren talboren merged commit 0ad65f7 into keephq:main Aug 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private presets are being pushed as part of async-presets message
2 participants