Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support update ticket jira and jira on-prem #1588

Merged
merged 24 commits into from
Sep 1, 2024

Conversation

ezhil56x
Copy link
Contributor

Closes #1567

📑 Description

Added support for updating jira and jira on-prem tickets

Click to expand
2024-08-11.23-05-31.mp4
Click to expand
2024-08-11.23-11-23.mp4

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

/claim #1567

Copy link

vercel bot commented Aug 11, 2024

@ezhil56x is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments. Thank you for the contribution!

keep/providers/jira_provider/jira_provider.py Outdated Show resolved Hide resolved
keep/providers/jira_provider/jira_provider.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.21%. Comparing base (6d5c759) to head (6d64f6f).
Report is 21 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1588       +/-   ##
===========================================
+ Coverage   30.68%   68.21%   +37.52%     
===========================================
  Files          54      121       +67     
  Lines        5028     9883     +4855     
===========================================
+ Hits         1543     6742     +5199     
+ Misses       3485     3141      -344     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@talboren talboren self-requested a review August 18, 2024 08:41
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still 2 small comments 🙏🏼

@talboren talboren self-assigned this Aug 18, 2024
Matvey-Kuk
Matvey-Kuk previously approved these changes Aug 19, 2024
@talboren talboren dismissed Matvey-Kuk’s stale review August 21, 2024 13:05

This PR is still incomplete.

@talboren talboren self-requested a review August 30, 2024 08:06
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@talboren talboren enabled auto-merge (squash) August 30, 2024 08:07
Copy link

vercel bot commented Sep 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2024 3:40pm

@talboren talboren merged commit f65e85b into keephq:main Sep 1, 2024
10 checks passed
@ezhil56x ezhil56x deleted the jira-update branch October 7, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🔌 Provider]: JIRA and JIRA on-prem providers to support updating ticket
4 participants