Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: servicenow cmdb and topology mapping #1825

Merged
merged 13 commits into from
Sep 8, 2024

Conversation

talboren
Copy link
Member

@talboren talboren commented Sep 4, 2024

close #1826

Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Sep 8, 2024 8:10am

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 34.00000% with 33 lines in your changes missing coverage. Please review.

Project coverage is 31.27%. Comparing base (ac7eae1) to head (1e63e84).
Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/bl/enrichments_bl.py 4.16% 23 Missing ⚠️
keep/api/core/db.py 16.66% 5 Missing ⚠️
keep/api/models/db/mapping.py 70.00% 3 Missing ⚠️
keep/api/tasks/process_event_task.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1825       +/-   ##
===========================================
- Coverage   68.36%   31.27%   -37.09%     
===========================================
  Files         120       55       -65     
  Lines        9839     5068     -4771     
===========================================
- Hits         6726     1585     -5141     
- Misses       3113     3483      +370     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@talboren talboren force-pushed the feat/servicenow-cmdb-and-auto-mapping branch from fab6d20 to e1f300e Compare September 5, 2024 12:52
@talboren talboren changed the title [WIP] feat: servicenow cmdb and topology mapping feat: servicenow cmdb and topology mapping Sep 5, 2024
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@talboren talboren merged commit b2e3df8 into main Sep 8, 2024
13 checks passed
@talboren talboren deleted the feat/servicenow-cmdb-and-auto-mapping branch September 8, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: ServiceNow CMDB and topology mapping
2 participants