Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding incident workflow triggers #1861

Merged
merged 18 commits into from
Sep 19, 2024

Conversation

VladimirFilonov
Copy link
Contributor

Closes #1527

📑 Description

This PR introduces a new trigger type for the Keep workflow: incident triggers. Now, workflows can start based on different incident events: created, updated, or deleted. User can choose one or multiple events in a single workflow.

Screen.Recording.2024-09-08.at.01.19.16.mov

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Copy link

vercel bot commented Sep 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 8:13am

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 67.26190% with 55 lines in your changes missing coverage. Please review.

Project coverage is 67.33%. Comparing base (ac7eae1) to head (929943f).
Report is 57 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/routes/incidents.py 2.94% 33 Missing ⚠️
keep/api/models/alert.py 66.66% 6 Missing ⚠️
keep/api/core/db.py 44.44% 5 Missing ⚠️
keep/workflowmanager/workflowmanager.py 84.37% 5 Missing ⚠️
keep/step/step.py 0.00% 3 Missing ⚠️
keep/workflowmanager/workflowscheduler.py 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1861      +/-   ##
==========================================
- Coverage   68.36%   67.33%   -1.03%     
==========================================
  Files         120      142      +22     
  Lines        9839    11392    +1553     
==========================================
+ Hits         6726     7671     +945     
- Misses       3113     3721     +608     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VladimirFilonov VladimirFilonov force-pushed the feature/1527-feature-incident-workflow-trigger branch from 929943f to 38ddb3f Compare September 8, 2024 09:21
Copy link

gitguardian bot commented Sep 10, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@VladimirFilonov VladimirFilonov force-pushed the feature/1527-feature-incident-workflow-trigger branch 2 times, most recently from 465a22f to dbb39e6 Compare September 12, 2024 08:35
@VladimirFilonov VladimirFilonov force-pushed the feature/1527-feature-incident-workflow-trigger branch from b1eea1a to 745c593 Compare September 18, 2024 08:52
@VladimirFilonov VladimirFilonov force-pushed the feature/1527-feature-incident-workflow-trigger branch 3 times, most recently from 3bbc1d9 to 476d8ca Compare September 18, 2024 12:41
@talboren talboren self-requested a review September 18, 2024 15:36
talboren
talboren previously approved these changes Sep 18, 2024
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@VladimirFilonov VladimirFilonov merged commit 286e303 into main Sep 19, 2024
13 checks passed
@VladimirFilonov VladimirFilonov deleted the feature/1527-feature-incident-workflow-trigger branch September 19, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Incident workflow trigger
3 participants