Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: topology applications api #1984

Conversation

Kiryous
Copy link
Contributor

@Kiryous Kiryous commented Sep 22, 2024

Closes #1968

📑 Description

Add CRUD for Topology Applications

Copy link

vercel bot commented Sep 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 7:41pm

@Kiryous Kiryous changed the base branch from main to feature/1968-topology-applications September 22, 2024 14:54
@Kiryous Kiryous changed the title Feature/1968 topology applications api feat: topology applications api Sep 22, 2024
keep/api/routes/topology.py Outdated Show resolved Hide resolved
keep/api/routes/topology.py Outdated Show resolved Hide resolved
keep/api/routes/topology.py Outdated Show resolved Hide resolved
keep/api/routes/topology.py Outdated Show resolved Hide resolved
keep/api/routes/topology.py Outdated Show resolved Hide resolved
keep/api/routes/topology.py Show resolved Hide resolved
keep/api/routes/topology.py Outdated Show resolved Hide resolved
keep/topologies/topologies_service.py Outdated Show resolved Hide resolved
keep/api/routes/topology.py Outdated Show resolved Hide resolved
keep/topologies/topologies_service.py Show resolved Hide resolved
Copy link
Contributor

@Matvey-Kuk Matvey-Kuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! We usually try to cover all new endpoints with tests. Also, please don’t forget to generate docs for new endpoints

@Matvey-Kuk
Copy link
Contributor

For docs: https://github.com/keephq/keep/blob/main/scripts/docs_generate_api_docs_from_openapi.sh

@Kiryous Kiryous requested a review from Matvey-Kuk September 23, 2024 17:34
Copy link
Contributor

@Matvey-Kuk Matvey-Kuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but checked only backend code <3

@Kiryous
Copy link
Contributor Author

Kiryous commented Sep 24, 2024

@Matvey-Kuk thanks! This PR is targeted to feature branch and the scope is only backend.

@Kiryous Kiryous merged commit 7f69917 into feature/1968-topology-applications Sep 24, 2024
11 checks passed
@Kiryous Kiryous deleted the feature/1968-topology-applications-api branch September 24, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[➕ Feature] Allow to group services into applications in topology
5 participants