Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): remove hiding navbar on MB Air-screen-size fixes #2023

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

Matvey-Kuk
Copy link
Contributor

@Matvey-Kuk Matvey-Kuk commented Sep 29, 2024

Stop hiding menu for small screen owners 😅:
Before:
Screenshot 2024-09-29 at 13 33 57
After:
Screenshot 2024-09-29 at 13 14 58

  • readable incident page
    Before:
Screenshot 2024-09-29 at 13 35 33

After:
Screenshot 2024-09-29 at 13 35 00

Closes #2032

Copy link

vercel bot commented Sep 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Sep 29, 2024 6:03pm

@Matvey-Kuk Matvey-Kuk changed the title MB Air-screen-size fixes fix: MB Air-screen-size fixes Sep 29, 2024
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.04%. Comparing base (0f8ab69) to head (9b30ea2).
Report is 41 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2023       +/-   ##
===========================================
- Coverage   69.40%   31.04%   -38.37%     
===========================================
  Files         145       57       -88     
  Lines       11810     5949     -5861     
===========================================
- Hits         8197     1847     -6350     
- Misses       3613     4102      +489     
Flag Coverage Δ
31.04% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahargl shahargl changed the title fix: MB Air-screen-size fixes fix(ui): remove hiding navbar on MB Air-screen-size fixes Sep 29, 2024
@Matvey-Kuk Matvey-Kuk enabled auto-merge (squash) September 29, 2024 11:36
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it’s tested and works LGTM!

@Matvey-Kuk Matvey-Kuk merged commit 3aca0f4 into main Sep 29, 2024
11 checks passed
@Matvey-Kuk Matvey-Kuk deleted the Matvey-Kuk/small-screen-tiny-fixes branch September 29, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[👨🏻‍💻 Internal]: remove hiding navbar on MB Air-screen-size fixes
2 participants