Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(incident): activity tab #2185

Merged
merged 13 commits into from
Oct 21, 2024
Merged

feat(incident): activity tab #2185

merged 13 commits into from
Oct 21, 2024

Conversation

talboren
Copy link
Member

@talboren talboren commented Oct 13, 2024

CleanShot.2024-10-13.at.15.22.04.mp4

@talboren talboren linked an issue Oct 13, 2024 that may be closed by this pull request
Copy link

vercel bot commented Oct 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 1:01pm

@shahargl
Copy link
Member

👏

@talboren
Copy link
Member Author

I can't seem to fix the bug with the icons that gets messy after a few new items, I've created this to see if the maintainer could maybe help us out: prabhuignoto/react-chrono#509

@talboren talboren force-pushed the 2128--feature-incident-activity branch from a85e06d to e4ad76e Compare October 21, 2024 07:16
Copy link
Contributor

@Kiryous Kiryous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Left a few comments, otherwise it's good to go!

keep-ui/app/incidents/[id]/incident-activity.tsx Outdated Show resolved Hide resolved
keep-ui/app/incidents/[id]/incident-activity.tsx Outdated Show resolved Hide resolved
Co-authored-by: Kirill Chernakov <[email protected]>
Signed-off-by: Tal <[email protected]>
@talboren
Copy link
Member Author

@Kiryous applied your suggestions! lmk if you're good with it and let's push it in :)

Copy link
Contributor

@Kiryous Kiryous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@talboren talboren merged commit 7bf3c83 into main Oct 21, 2024
10 checks passed
@talboren talboren deleted the 2128--feature-incident-activity branch October 21, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Incident Activity
3 participants