-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new metric widgets #2261
feat: new metric widgets #2261
Conversation
Signed-off-by: 35C4n0r <[email protected]>
@35C4n0r is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
Signed-off-by: 35C4n0r <[email protected]>
Signed-off-by: 35C4n0r <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
@35C4n0r What if I want to see the previous day's data? how are we handling it |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@35C4n0r may I ask you to resolve the conflict, and run linter? For example, please note that every other component, the standard is using " instad of '.
May I also ask you to upload a video of how this feature looks like?
cc: @Matvey-Kuk - I know you approved but would love to see that ^ first.
re @rajeshj11: @Matvey-Kuk @35C4n0r I think it's a valid point. As a user I would like the dashboard to work with the timeframe I chose.
# Conflicts: # keep-ui/app/dashboard/[id]/dashboard.tsx
Conflict Resolved, is the command for linter
Didn't understand, can you clarify this.
It's there in the description
Ok, then instead of the past 24 hours, should we show the graph for per day? Thoughts? |
π
|
@35C4n0r note: not certain. please get approval from @Matvey-Kuk @talboren before you even start devlopment. The above assumption is my perspective. |
π @rajeshj11 that's definitely not what I meant. Let me rephrase it a bit: |
I understand your point, and I see it from that perspective as well. Iβve also noted in my comments that this is based purely on my assumption as a user. |
@35C4n0r Let @Matvey-Kuk and @talboren decide which one they want. If you're open to it, I'd like to collaborate with you to tackle this blocker together. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2261 +/- ##
==========================================
- Coverage 71.20% 71.15% -0.06%
==========================================
Files 154 155 +1
Lines 14046 14476 +430
==========================================
+ Hits 10002 10300 +298
- Misses 4044 4176 +132 β View full report in Codecov by Sentry. |
Signed-off-by: 35C4n0r <[email protected]>
Signed-off-by: 35C4n0r <[email protected]>
β¦into feat-dashboards-re
@35C4n0r if changes are done. Can you please add demo video if possible. |
Co-authored-by: Vladimir Filonov <[email protected]> Signed-off-by: Jay Kumar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking really good for me. I see tests are failing, please fix them :)
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
8134198 | Triggered | Generic High Entropy Secret | 9d3bab0 | keep-ui/app/frigade-provider.tsx | View secret |
14332896 | Triggered | Generic Password | 4adf359 | keep/providers/graylog_provider/docker-compose.yml | View secret |
π Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
π¦ GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Signed-off-by: 35C4n0r <[email protected]>
@Matvey-Kuk tests were failing sporadically, they all pass now. I've updated the docs. Lemme know if any other changes are required and let's get this PR merged :) |
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's great!
Closes #1769
Closes #2262
π Description
β Checks
βΉ Additional Information
https://www.loom.com/share/aa665dee5b2c413dac14976ed62e90fe?sid=00b8c786-a87a-47d7-a17f-a6dbe74de11f