Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migrations): db's other than sqlite #2276

Merged
merged 3 commits into from
Oct 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,23 @@ def upgrade() -> None:
with op.batch_alter_table("provider", schema=None) as batch_op:
batch_op.alter_column("pulling_enabled", nullable=False)
else:
# Implementation for other databases
with op.batch_alter_table("provider", schema=None) as batch_op:
batch_op.add_column(
sa.Column(
"pulling_enabled",
sa.Boolean(),
nullable=False,
server_default=sa.true(),
)
)
# PostgreSQL and other databases implementation
# 1. Add the column as nullable
op.add_column(
"provider", sa.Column("pulling_enabled", sa.Boolean(), nullable=True)
)
# 2. Set default value for existing rows
op.execute(
"UPDATE provider SET pulling_enabled = true WHERE pulling_enabled IS NULL"
)
# 3. Make it non-nullable with default
op.alter_column(
"provider",
"pulling_enabled",
existing_type=sa.Boolean(),
nullable=False,
server_default=sa.true(),
)


def downgrade() -> None:
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "keep"
version = "0.27.2"
version = "0.27.3"
description = "Alerting. for developers, by developers."
authors = ["Keep Alerting LTD"]
readme = "README.md"
Expand Down
Loading