-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Graylog Provider #2305
Conversation
Signed-off-by: 35C4n0r <[email protected]>
Signed-off-by: 35C4n0r <[email protected]>
@35C4n0r is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
- | - | Generic Password | e674243 | keep/providers/graylog_provider/docker-compose.yml | View secret |
π Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
π¦ GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Signed-off-by: 35C4n0r <[email protected]>
Signed-off-by: 35C4n0r <[email protected]>
Looks great so far. One question that I have - is that only self hosted graylog or also cloud? |
Signed-off-by: 35C4n0r <[email protected]>
β¦-graylog-provider
@shahargl, this is for self-hosted, This is the only thing I have found regarding Graylog Cloud https://go2docs.graylog.org/current/what_is_graylog/what_is_graylog_cloud.html?Highlight=cloud |
Signed-off-by: 35C4n0r <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #2305 +/- ##
==========================================
- Coverage 71.20% 71.20% -0.01%
==========================================
Files 154 157 +3
Lines 14046 14509 +463
==========================================
+ Hits 10002 10331 +329
- Misses 4044 4178 +134 β View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comments, few small things:
- the issue with admin role (add docs if its required)
- convention
- please add docs about how to connect Keep as webhook without installing it so it won't need credentials at all (like google monitoring provider)
Signed-off-by: 35C4n0r <[email protected]>
Signed-off-by: 35C4n0r <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@35C4n0r its close to being done, let's merge it today
Signed-off-by: 35C4n0r <[email protected]>
β¦-graylog-provider
Signed-off-by: 35C4n0r <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The latest updates on your projects. Learn more about Vercel for Git βοΈ 1 Skipped Deployment
|
Closes #2283
π Description
β Checks
βΉ Additional Information
https://www.loom.com/share/faaf3fe4d3714810bf7617dd5d4fe461?sid=df16e29a-d39c-4b5c-9966-6fdd0044cab5