Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Graylog Provider #2305

Merged
merged 17 commits into from
Oct 29, 2024
Merged

Conversation

35C4n0r
Copy link
Contributor

@35C4n0r 35C4n0r commented Oct 26, 2024

Closes #2283

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

https://www.loom.com/share/faaf3fe4d3714810bf7617dd5d4fe461?sid=df16e29a-d39c-4b5c-9966-6fdd0044cab5

Signed-off-by: 35C4n0r <[email protected]>
Signed-off-by: 35C4n0r <[email protected]>
Copy link

vercel bot commented Oct 26, 2024

@35C4n0r is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Oct 26, 2024
Copy link

gitguardian bot commented Oct 26, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

πŸ”Ž Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Generic Password e674243 keep/providers/graylog_provider/docker-compose.yml View secret
πŸ›  Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


πŸ¦‰ GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@dosubot dosubot bot added Documentation Improvements or additions to documentation Feature A new feature Provider Providers related issues labels Oct 26, 2024
Signed-off-by: 35C4n0r <[email protected]>
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Oct 26, 2024
Signed-off-by: 35C4n0r <[email protected]>
@shahargl
Copy link
Member

Looks great so far. One question that I have - is that only self hosted graylog or also cloud?

@35C4n0r
Copy link
Contributor Author

35C4n0r commented Oct 26, 2024

@shahargl, this is for self-hosted, This is the only thing I have found regarding Graylog Cloud https://go2docs.graylog.org/current/what_is_graylog/what_is_graylog_cloud.html?Highlight=cloud

Signed-off-by: 35C4n0r <[email protected]>
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 71.20%. Comparing base (7d90ae9) to head (1db891e).
Report is 52 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2305      +/-   ##
==========================================
- Coverage   71.20%   71.20%   -0.01%     
==========================================
  Files         154      157       +3     
  Lines       14046    14509     +463     
==========================================
+ Hits        10002    10331     +329     
- Misses       4044     4178     +134     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@shahargl shahargl self-requested a review October 27, 2024 07:58
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments, few small things:

  1. the issue with admin role (add docs if its required)
  2. convention
  3. please add docs about how to connect Keep as webhook without installing it so it won't need credentials at all (like google monitoring provider)

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Oct 27, 2024
Signed-off-by: 35C4n0r <[email protected]>
@35C4n0r 35C4n0r requested a review from shahargl October 27, 2024 14:20
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@35C4n0r its close to being done, let's merge it today

@35C4n0r 35C4n0r requested a review from shahargl October 29, 2024 09:10
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 29, 2024
@shahargl shahargl enabled auto-merge (squash) October 29, 2024 10:09
Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 10:10am

@shahargl shahargl merged commit ab8c6ff into keephq:main Oct 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Feature A new feature lgtm This PR has been approved by a maintainer Provider Providers related issues size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[πŸ”Œ Provider]: graylog
3 participants