Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update authverifierbase.py #2337

Closed
wants to merge 1 commit into from
Closed

Conversation

DhruvKadam-git
Copy link
Contributor

  1. Improve Logging: Added more descriptive logging messages to help with debugging.

  2. Refactor Error Handling: Simplified the error handling in the authenticate method.

  3. Type Hinting: Added type hints for the _provision_user method parameters for clarity.

Closes #

📑 Description

✅ Checks

  • [ x] My pull request adheres to the code style of this project
  • [ x] My code requires changes to the documentation
  • [ x] I have updated the documentation as required
  • [ x] All the tests have passed

ℹ Additional Information

1. Improve Logging: Added more descriptive logging messages to help with debugging.

2. Refactor Error Handling: Simplified the error handling in the authenticate method.

3. Type Hinting: Added type hints for the _provision_user method parameters for clarity.

Signed-off-by: Dhruv Kadam <[email protected]>
Copy link

vercel bot commented Oct 29, 2024

@DhruvKadam-git is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 29, 2024
Copy link
Contributor

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

@shahargl
Copy link
Member

?
you just removed documentation

@shahargl shahargl closed this Oct 29, 2024
@DhruvKadam-git
Copy link
Contributor Author

sorry think I have uploded wrong piece of code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants