Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migration messing link between alerts and incidents #2338

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

Matvey-Kuk
Copy link
Contributor

@Matvey-Kuk Matvey-Kuk commented Oct 29, 2024

Close: #2302

Some context:

  • Using pure SQL to make sure future changes of the python model won't break it.
  • I don't fix original migration, but create a new one. It should fix the issue for those who already executed the first one.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 29, 2024
Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Oct 29, 2024 3:03pm

@Matvey-Kuk Matvey-Kuk changed the title Fix: migration messing link between alerts and incidents fix: migration messing link between alerts and incidents Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.52%. Comparing base (7d90ae9) to head (0a19c45).
Report is 65 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2338      +/-   ##
==========================================
+ Coverage   71.20%   71.52%   +0.31%     
==========================================
  Files         154      158       +4     
  Lines       14046    14692     +646     
==========================================
+ Hits        10002    10508     +506     
- Misses       4044     4184     +140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@VladimirFilonov VladimirFilonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 29, 2024
@Matvey-Kuk Matvey-Kuk merged commit 46c8635 into main Oct 30, 2024
15 of 17 checks passed
@Matvey-Kuk Matvey-Kuk deleted the Matvey-Kuk/fix-migration-messing-sqlite branch October 30, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: deleted_at default is wrong (at least for sqlite) and migration breaks incidents alerts
2 participants