Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: GCP logging and friends 🏄‍♂️ #2369

Merged
merged 4 commits into from
Oct 31, 2024
Merged

feat: GCP logging and friends 🏄‍♂️ #2369

merged 4 commits into from
Oct 31, 2024

Conversation

talboren
Copy link
Member

No description provided.

@talboren talboren linked an issue Oct 31, 2024 that may be closed by this pull request
[🔌 Provider]: GCP Monitoring to be able to query logs #2355
Closed
@vercel Vercel
Copy link

vercel bot commented Oct 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Oct 31, 2024 4:08pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Documentation Improvements or additions to documentation Feature A new feature Provider Providers related issues labels Oct 31, 2024
VladimirFilonov
VladimirFilonov approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@VladimirFilonov VladimirFilonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 31, 2024
@talboren talboren merged commit 23d4c65 into main Oct 31, 2024
12 checks passed
@talboren talboren deleted the 2355-provider-gcp-monitoring-to-be-able-to-query-logs branch October 31, 2024 16:19
@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.20%. Comparing base (7d90ae9) to head (e880dc4).
Report is 72 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2369       +/-   ##
===========================================
- Coverage   71.20%   31.20%   -40.01%     
===========================================
  Files         154       63       -91     
  Lines       14046     6826     -7220     
===========================================
- Hits        10002     2130     -7872     
- Misses       4044     4696      +652

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirFilonov VladimirFilonov VladimirFilonov approved these changes

Assignees
No one assigned
Labels
Documentation Improvements or additions to documentation Feature A new feature lgtm This PR has been approved by a maintainer Provider Providers related issues size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🔌 Provider]: GCP Monitoring to be able to query logs
2 participants
@talboren @VladimirFilonov