Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: BaseIncidentProvider, PagerDuty incidents and process_incident #2394

Merged
merged 38 commits into from
Nov 12, 2024

Conversation

35C4n0r
Copy link
Contributor

@35C4n0r 35C4n0r commented Nov 4, 2024

Closes #1502

📑 Description

  • Implemented BaseIncidentProvider providers can now get incidents.
  • New endpoint /incidents/events/{...}?..., we can receive events via webhook that maps to incidents.
  • Pagerduty Incident now maps to Keep's incidents
  • We can fetch service topology from PagerDuty and display it in keep
  • Fixed a bug in Topology which didn't delete the entries in topologyservicedependency on the deletion of entries in topologyservice which led to redundant service dependencies everytime we fetched topology.

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

https://www.loom.com/share/338f561b5dbc494e8736291e27c98eee?sid=add4bbc7-9963-4b15-b1c1-072ac74ee43e

- incidents are mapped to incidents
- pagerduty installed via oauth

Signed-off-by: 35C4n0r <[email protected]>
Signed-off-by: 35C4n0r <[email protected]>
Signed-off-by: 35C4n0r <[email protected]>
Signed-off-by: 35C4n0r <[email protected]>
Signed-off-by: 35C4n0r <[email protected]>
# Conflicts:
#	keep/api/core/db.py
#	keep/api/routes/incidents.py
#	keep/providers/base/base_provider.py
Signed-off-by: 35C4n0r <[email protected]>
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Nov 4, 2024
Copy link

vercel bot commented Nov 4, 2024

@35C4n0r is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added Feature A new feature Provider Providers related issues labels Nov 4, 2024
keep/api/core/db.py Outdated Show resolved Hide resolved
# Conflicts:
#	keep/api/routes/providers.py
@35C4n0r 35C4n0r requested a review from shahargl November 5, 2024 16:52
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Nov 10, 2024
@talboren talboren changed the title [WIP] feat: map pagerduty incidents to keep incidents feat: BaseIncidentProvider, PagerDuty incidents and process_incident Nov 10, 2024
Copy link

vercel bot commented Nov 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 8:43am

Copy link
Contributor Author

@35C4n0r 35C4n0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @talboren. LGTM.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Nov 11, 2024
@Matvey-Kuk Matvey-Kuk self-requested a review November 11, 2024 08:10
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@talboren talboren dismissed their stale review November 12, 2024 08:56

Not relevant anymore

@talboren talboren merged commit e9e401c into keephq:main Nov 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new feature lgtm This PR has been approved by a maintainer Provider Providers related issues size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🔨 Enhancement]: Incident-supporting providers should pull Incidents instead of Alerts
3 participants