Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(provider): zabbix from mediatype to script #2397

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

talboren
Copy link
Member

@talboren talboren commented Nov 5, 2024

No description provided.

@talboren talboren linked an issue Nov 5, 2024 that may be closed by this pull request
Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 0:28am

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Documentation Improvements or additions to documentation Provider Providers related issues labels Nov 5, 2024
@talboren talboren changed the title 1964 provider zabbix improvements chore(provider): zabbix from mediatype to script Nov 5, 2024
Matvey-Kuk
Matvey-Kuk previously approved these changes Nov 5, 2024
docs/providers/overview.mdx Show resolved Hide resolved
docs/overview/introduction.mdx Show resolved Hide resolved
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 5, 2024
shahargl
shahargl previously approved these changes Nov 5, 2024
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@talboren talboren linked an issue Nov 5, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.32%. Comparing base (7d90ae9) to head (b23e729).
Report is 82 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2397       +/-   ##
===========================================
- Coverage   71.20%   31.32%   -39.89%     
===========================================
  Files         154       63       -91     
  Lines       14046     6871     -7175     
===========================================
- Hits        10002     2152     -7850     
- Misses       4044     4719      +675     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahargl shahargl self-requested a review November 5, 2024 12:35
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@talboren talboren merged commit 8ef0d80 into main Nov 5, 2024
13 of 14 checks passed
@talboren talboren deleted the 1964-provider-zabbix-improvements branch November 5, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer Provider Providers related issues size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Provider installed even if scopes are invalid [🔌 Provider]: Zabbix improvements
3 participants