Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): keep the failed alerts #2419

Merged
merged 5 commits into from
Nov 11, 2024
Merged

feat(api): keep the failed alerts #2419

merged 5 commits into from
Nov 11, 2024

Conversation

shahargl
Copy link
Member

@shahargl shahargl commented Nov 8, 2024

close #2418

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 8:28am

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. API API related issues Feature A new feature labels Nov 8, 2024
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 8, 2024
@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Nov 10, 2024
@shahargl shahargl requested a review from talboren November 11, 2024 08:30
Copy link
Contributor

@VladimirFilonov VladimirFilonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 11, 2024
@shahargl shahargl enabled auto-merge (squash) November 11, 2024 08:40
@shahargl shahargl merged commit c9b4812 into main Nov 11, 2024
11 checks passed
@shahargl shahargl deleted the feature/keep-failed-alerts branch November 11, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API related issues Feature A new feature lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Keep failed alerts
3 participants