Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): azure ad + permissions + multiple fixes in UI #2429

Merged
merged 22 commits into from
Nov 11, 2024

Conversation

shahargl
Copy link
Member

close #2428

Copy link

vercel bot commented Nov 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Nov 10, 2024 5:46pm

Copy link

gitguardian bot commented Nov 10, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8134198 Triggered Generic High Entropy Secret 690c34c keep-ui/app/frigade-provider.tsx View secret
8134198 Triggered Generic High Entropy Secret aaca072 keep-ui/app/frigade-provider.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. Documentation Improvements or additions to documentation Feature A new feature UI User interface related issues labels Nov 10, 2024
talboren
talboren previously approved these changes Nov 10, 2024
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yolo

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 10, 2024
@shahargl shahargl requested a review from talboren November 10, 2024 15:52
talboren
talboren previously approved these changes Nov 10, 2024
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 35.48387% with 20 lines in your changes missing coverage. Please review.

Project coverage is 31.28%. Comparing base (7d90ae9) to head (54cf97f).
Report is 92 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/core/db.py 29.41% 12 Missing ⚠️
keep/rulesengine/rulesengine.py 37.50% 5 Missing ⚠️
keep/searchengine/searchengine.py 50.00% 2 Missing ⚠️
keep/identitymanager/identitymanager.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2429       +/-   ##
===========================================
- Coverage   71.20%   31.28%   -39.92%     
===========================================
  Files         154       63       -91     
  Lines       14046     6884     -7162     
===========================================
- Hits        10002     2154     -7848     
- Misses       4044     4730      +686     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shahargl shahargl merged commit 963e9a3 into main Nov 11, 2024
12 of 14 checks passed
@shahargl shahargl deleted the feature/azuread branch November 11, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Feature A new feature lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files. UI User interface related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Azure AD authentication
2 participants