Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hardcoded app ID for the Azure AD #2440

Merged
merged 2 commits into from
Nov 11, 2024
Merged

fix: hardcoded app ID for the Azure AD #2440

merged 2 commits into from
Nov 11, 2024

Conversation

Matvey-Kuk
Copy link
Contributor

@Matvey-Kuk Matvey-Kuk commented Nov 11, 2024 •
edited
Loading

None

Closes #2441

@vercel Vercel
Copy link

vercel bot commented Nov 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 4:45pm

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 11, 2024
@Matvey-Kuk Matvey-Kuk mentioned this pull request Nov 11, 2024
Closed
@dosubot dosubot bot added the Bug Something isn't working label Nov 11, 2024
@Matvey-Kuk Matvey-Kuk changed the title Fix hardcoded app ID for the Azure AD fix: hardcoded app ID for the Azure AD Nov 11, 2024
@Matvey-Kuk Matvey-Kuk enabled auto-merge (squash) November 11, 2024 16:41
shahargl
shahargl approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 11, 2024
@Matvey-Kuk Matvey-Kuk merged commit 3aaa8c6 into main Nov 11, 2024
10 checks passed
@Matvey-Kuk Matvey-Kuk deleted the Matvey-Kuk/fix-hardcoded-app-id branch November 11, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahargl shahargl shahargl approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[👨🏻‍💻 Internal]: Fix hardcoded app ID for the Azure AD
2 participants
@Matvey-Kuk @shahargl