Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more indicative errors when connecting providers #2443

Conversation

talboren
Copy link
Member

No description provided.

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 8:33am

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. Bug Something isn't working Provider Providers related issues labels Nov 12, 2024
@talboren talboren enabled auto-merge (squash) November 12, 2024 08:29
@talboren talboren merged commit 21d4aab into main Nov 12, 2024
10 of 11 checks passed
@talboren talboren deleted the 2442-bug-ui-improvement-when-connecting-providers-and-no-connection branch November 12, 2024 08:35
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
Copy link
Contributor

@Kiryous Kiryous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review 🌚

);
} else if (updatedFormErrors.includes("Failed to fetch")) {
setFormErrors(
"Failed to connect to API: Check your internet connection"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some providers have the API host setting and it could be the problem.

Suggested change
"Failed to connect to API: Check your internet connection"
"Failed to connect to API: Check provider settings and your internet connection"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working lgtm This PR has been approved by a maintainer Provider Providers related issues size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: UI improvement when connecting providers and no connection
3 participants