Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): read only #2499

Merged
merged 5 commits into from
Nov 17, 2024
Merged

feat(api): read only #2499

merged 5 commits into from
Nov 17, 2024

Conversation

shahargl
Copy link
Member

close #2498

@vercel Vercel
Copy link

vercel bot commented Nov 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Nov 17, 2024 8:29am

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. API API related issues Feature A new feature labels Nov 15, 2024
@talboren
Copy link
Member

1 thing we'll need to consider: how can we let someone "bypass" read only, i.e., the simulate_alert script or something

@shahargl
Copy link
Member Author

@talboren added KEEP_READ_ONLY_BYPASS_KEY that, together with KEEP_DEFAULT_API_KEYS can do it.

Start Keep with

KEEP_READ_ONLY_BYPASS_KEY=1234
KEEP_DEFAULT_API_KEYS=admin_api_key:admin:1234

talboren
talboren previously approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 17, 2024
@shahargl shahargl requested a review from talboren November 17, 2024 08:30
talboren
talboren approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahargl shahargl merged commit 0a62143 into main Nov 17, 2024
11 checks passed
@shahargl shahargl deleted the feature/read-only branch November 17, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talboren talboren talboren approved these changes

Assignees
No one assigned
Labels
API API related issues Feature A new feature lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Read Only mode
2 participants
@shahargl @talboren