Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor fix in gcp monitoring #2519

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix: minor fix in gcp monitoring #2519

merged 2 commits into from
Nov 18, 2024

Conversation

shahargl
Copy link
Member

@shahargl shahargl commented Nov 18, 2024

close #2518

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2024 9:49am

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 18, 2024
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description can be empty too, it seems :(

Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 18, 2024
@shahargl shahargl merged commit e121f23 into main Nov 18, 2024
13 checks passed
@shahargl shahargl deleted the bugfix/gcpmonitoring branch November 18, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: GCPMonitoring documentation is broken
2 participants