Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): azuread behind proxy #2576

Merged
merged 15 commits into from
Nov 24, 2024
Merged

feat(auth): azuread behind proxy #2576

merged 15 commits into from
Nov 24, 2024

Conversation

shahargl
Copy link
Member

close #2575

@vercel Vercel
Copy link

vercel bot commented Nov 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2024 5:28pm

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. Feature A new feature UI User interface related issues labels Nov 21, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 23, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 24, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.13%. Comparing base (892a79e) to head (06213ed).
Report is 23 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2576       +/-   ##
===========================================
- Coverage   69.63%   31.13%   -38.50%     
===========================================
  Files         160       64       -96     
  Lines       15149     7027     -8122     
===========================================
- Hits        10549     2188     -8361     
- Misses       4600     4839      +239

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

talboren
talboren approved these changes Nov 24, 2024
View reviewed changes
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 24, 2024
@shahargl shahargl merged commit fcb8bd6 into main Nov 24, 2024
12 of 14 checks passed
@shahargl shahargl deleted the feature/azure-proxy branch November 24, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talboren talboren talboren approved these changes

Assignees
No one assigned
Labels
Feature A new feature lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files. UI User interface related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: AzureAD behind proxy
2 participants
@shahargl @talboren