fix: workflow id and name usage #2685
Closed
+52
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to keephq#1885 Update workflow parsing to use `id` as id and `name` as name, generate different UUID if `id` is not provided, and add validation for configuration errors. * **keep/parser/parser.py** - Update `_get_workflow_id` to use `workflow.get("id")` for id and `workflow.get("name")` for name. - Add logic to generate a different UUID if `workflow.get("id")` is not provided. - Update `_parse_workflow` to use `workflow.get("name")` for name. * **keep/api/models/db/workflow.py** - Add a new field `invalid` to mark workflows with configuration errors. - Update the `Workflow` class to include the `invalid` field. * **keep/api/routes/workflows.py** - Update `create_workflow` and `create_workflow_from_body` to generate a different UUID if `workflow.get("id")` is not provided. - Add validation logic to mark workflows with configuration errors as `invalid`. * **tests/test_parser.py** - Add test cases to verify that a different UUID is generated if `workflow.get("id")` is not provided. - Add test cases to verify that workflows with configuration errors are marked as `invalid`.
|
@vishwamartur is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
bot
added
the
size:M
|
|
|
No linked issues found. Please add the corresponding issues in the pull request description. |
talboren
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Matvey-Kuk
requested changes
Dec 16, 2024
|
This is open for more than a month. Closing for now, please re-open if it's relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1885
Update workflow parsing to use
idas id andnameas name, generate different UUID ifidis not provided, and add validation for configuration errors.keep/parser/parser.py
_get_workflow_idto useworkflow.get("id")for id andworkflow.get("name")for name.workflow.get("id")is not provided._parse_workflowto useworkflow.get("name")for name.keep/api/models/db/workflow.py
invalidto mark workflows with configuration errors.Workflowclass to include theinvalidfield.keep/api/routes/workflows.py
create_workflowandcreate_workflow_from_bodyto generate a different UUID ifworkflow.get("id")is not provided.invalid.tests/test_parser.py
workflow.get("id")is not provided.invalid.