Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multiple alerts matching rules PoC #2727

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

VladimirFilonov
Copy link
Contributor

@VladimirFilonov VladimirFilonov commented Dec 2, 2024

Closes #2776

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
keep βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Dec 17, 2024 10:25am

@VladimirFilonov VladimirFilonov force-pushed the feature/historical-rules-poc branch 2 times, most recently from a69f503 to 328620f Compare December 7, 2024 14:06
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 20.78652% with 141 lines in your changes missing coverage. Please review.

Project coverage is 43.87%. Comparing base (aa11b5d) to head (837847e).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
keep/rulesengine/rulesengine.py 21.79% 61 Missing ⚠️
tests/test_rules_engine.py 11.32% 47 Missing ⚠️
keep/api/core/db.py 19.04% 17 Missing ⚠️
keep/api/bl/incidents_bl.py 18.18% 9 Missing ⚠️
keep/api/routes/rules.py 25.00% 6 Missing ⚠️
keep/api/models/db/alert.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2727      +/-   ##
==========================================
- Coverage   44.05%   43.87%   -0.18%     
==========================================
  Files         158      158              
  Lines       15076    15185     +109     
==========================================
+ Hits         6642     6663      +21     
- Misses       8434     8522      +88     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@VladimirFilonov VladimirFilonov marked this pull request as ready for review December 8, 2024 18:19
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. Feature A new feature labels Dec 8, 2024
@VladimirFilonov VladimirFilonov force-pushed the feature/historical-rules-poc branch from f7a4a35 to e68c23e Compare December 8, 2024 18:21
@Matvey-Kuk Matvey-Kuk self-requested a review December 9, 2024 08:33
@VladimirFilonov VladimirFilonov force-pushed the feature/historical-rules-poc branch from e68c23e to 5bba42e Compare December 10, 2024 05:26
@VladimirFilonov VladimirFilonov changed the title feat: PoC rules with historical data feat: multiple alerts matching rules PoC Dec 10, 2024
@VladimirFilonov VladimirFilonov force-pushed the feature/historical-rules-poc branch from 0cb2d9e to 93bd91f Compare December 10, 2024 13:53
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. size:L This PR changes 100-499 lines, ignoring generated files. labels Dec 10, 2024
@VladimirFilonov VladimirFilonov force-pushed the feature/historical-rules-poc branch from 9192f13 to 837847e Compare December 12, 2024 12:27
Matvey-Kuk
Matvey-Kuk previously approved these changes Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new feature size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[βž• Feature]: incidents to be created only when multiple alerts matches rule
2 participants