Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slack): message is not required with attachments #2741

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

talboren
Copy link
Member

@talboren talboren commented Dec 3, 2024

No description provided.

Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 3:58pm

@talboren talboren linked an issue Dec 3, 2024 that may be closed by this pull request
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Bug Something isn't working labels Dec 3, 2024
@talboren talboren enabled auto-merge (squash) December 3, 2024 15:28
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Dec 3, 2024
@talboren talboren merged commit c0ba444 into main Dec 3, 2024
12 of 14 checks passed
@talboren talboren deleted the 2740-bug-slack-provider-no-message-with-attachments branch December 3, 2024 15:59
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.09%. Comparing base (3ddeacc) to head (db52be8).
Report is 11 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2741       +/-   ##
===========================================
- Coverage   44.07%   31.09%   -12.99%     
===========================================
  Files         156       67       -89     
  Lines       14837     7404     -7433     
===========================================
- Hits         6539     2302     -4237     
+ Misses       8298     5102     -3196     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Slack provider no message with attachments
2 participants