Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert validation for Slack provider to work with oauth #2765

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

talboren
Copy link
Member

@talboren talboren commented Dec 5, 2024

Slack does not work with OAuth anymore because of the new validation method, reverting #2430 for slack

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Dec 5, 2024 0:33am

@talboren talboren linked an issue Dec 5, 2024 that may be closed by this pull request
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Bug Something isn't working labels Dec 5, 2024
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 5, 2024
@talboren talboren merged commit 7c83bd4 into main Dec 5, 2024
13 of 14 checks passed
@talboren talboren deleted the 2764-bug-revert-slack-validation-for-webhook_url branch December 5, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Revert Slack validation for webhook_url
3 participants