Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better visibility #2775

Merged
merged 76 commits into from
Dec 15, 2024
Merged

feat: better visibility #2775

merged 76 commits into from
Dec 15, 2024

Conversation

talboren
Copy link
Member

@talboren talboren commented Dec 8, 2024

close #2806

  • Trace and spans in processing
  • Prometheus metrics for processing
  • SQLAlchemy 2
  • Psycopg 3
  • Opt-outs in different ETL process
  • Performance imporvements
  • Caching for some parts

Copy link

vercel bot commented Dec 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Dec 15, 2024 0:10am

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. Feature A new feature size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Dec 8, 2024
@talboren talboren changed the title feat: better observability feat: better visibility Dec 8, 2024
@talboren talboren force-pushed the feat/observability branch 2 times, most recently from 72d2c65 to 8235cc5 Compare December 9, 2024 15:09
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 58.14815% with 226 lines in your changes missing coverage. Please review.

Project coverage is 43.98%. Comparing base (aa11b5d) to head (4d4029b).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/tasks/process_event_task.py 61.90% 56 Missing ⚠️
keep/api/core/db.py 50.00% 54 Missing ⚠️
tests/test_deduplications.py 13.79% 50 Missing ⚠️
keep/api/api.py 70.37% 24 Missing ⚠️
keep/api/routes/alerts.py 71.42% 10 Missing ⚠️
tests/test_enrichments.py 10.00% 9 Missing ⚠️
keep/api/alert_deduplicator/alert_deduplicator.py 58.82% 7 Missing ⚠️
keep/api/bl/enrichments_bl.py 60.00% 6 Missing ⚠️
keep/api/routes/metrics.py 63.63% 4 Missing ⚠️
tests/conftest.py 81.25% 3 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2775      +/-   ##
==========================================
- Coverage   44.05%   43.98%   -0.08%     
==========================================
  Files         158      164       +6     
  Lines       15076    15676     +600     
==========================================
+ Hits         6642     6895     +253     
- Misses       8434     8781     +347     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 15, 2024
@talboren talboren merged commit d0ff56e into main Dec 15, 2024
12 checks passed
@talboren talboren deleted the feat/observability branch December 15, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new feature lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: More Visibility
2 participants