Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve the builder actions and form validations #2793

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

rajesh-jonnalagadda
Copy link
Contributor

Closes #2538

πŸ“‘ Description

improve the builder actions and form validations

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Dec 10, 2024
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
keep βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Dec 11, 2024 1:40pm

Copy link

vercel bot commented Dec 10, 2024

@rajesh-jonnalagadda is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added Feature A new feature UI User interface related issues labels Dec 10, 2024
@rajesh-jonnalagadda
Copy link
Contributor Author

rajesh-jonnalagadda commented Dec 10, 2024

@shahargl We are using Zod for form validation, which is currently configured to handle standard fields, standard tools(interval, incident, alert, assert, for each, threshold), and HTTP actions.

we can add zod-schema for other providers/tools too. if given the rules.

@Matvey-Kuk
Copy link
Contributor

Hey @rajesh-jonnalagadda could you please fix tests? Thank you :)

@Matvey-Kuk Matvey-Kuk requested a review from shahargl December 16, 2024 08:34
@rajesh-jonnalagadda
Copy link
Contributor Author

Hey @rajesh-jonnalagadda could you please fix tests? Thank you :)

I don't see any test failures; the only issue is that the Vercel deployment hasn't passed, as it requires approval from the internal team.

Copy link

gitguardian bot commented Dec 22, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

πŸ”Ž Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14884154 Triggered Username Password 87afe69 elk/docker-compose-elk.yml View secret
πŸ›  Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


πŸ¦‰ GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@talboren
Copy link
Member

@rajesh-jonnalagadda there's a conflict in here, mind checking on it so we can wrap this up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new feature size:XXL This PR changes 1000+ lines, ignoring generated files. UI User interface related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[βž• Feature]: Workflows Improvements - Actions
3 participants