-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve the builder actions and form validations #2793
base: main
Are you sure you want to change the base?
feat: improve the builder actions and form validations #2793
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
@rajesh-jonnalagadda is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
@shahargl We are using Zod for form validation, which is currently configured to handle standard fields, standard tools(interval, incident, alert, assert, for each, threshold), and HTTP actions. we can add zod-schema for other providers/tools too. if given the rules. |
Hey @rajesh-jonnalagadda could you please fix tests? Thank you :) |
I don't see any test failures; the only issue is that the Vercel deployment hasn't passed, as it requires approval from the internal team. |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
14884154 | Triggered | Username Password | 87afe69 | elk/docker-compose-elk.yml | View secret |
π Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
π¦ GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
@rajesh-jonnalagadda there's a conflict in here, mind checking on it so we can wrap this up? |
Signed-off-by: Rajesh Jonnalagadda <[email protected]>
Closes #2538
π Description
improve the builder actions and form validations
β Checks
βΉ Additional Information