Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add grafana legacy #2797

Merged
merged 14 commits into from
Dec 23, 2024
Merged

feat(api): add grafana legacy #2797

merged 14 commits into from
Dec 23, 2024

Conversation

shahargl
Copy link
Member

@shahargl shahargl commented Dec 10, 2024

close #2798

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 4:29pm

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. Feature A new feature Provider Providers related issues labels Dec 10, 2024
Copy link
Contributor

@Kiryous Kiryous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work! have a few comments on frontend

keep-ui/utils/hooks/useProviderLogs.ts Outdated Show resolved Hide resolved
keep-ui/utils/hooks/useProviderLogs.ts Outdated Show resolved Hide resolved
Copy link

gitguardian bot commented Dec 23, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8134198 Triggered Generic High Entropy Secret 7821e31 keep-ui/app/frigade-provider.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@shahargl shahargl requested a review from Kiryous December 23, 2024 16:01
Copy link
Contributor

@Kiryous Kiryous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things, otherwise awesome!

keep-ui/utils/hooks/useProviderLogs.ts Outdated Show resolved Hide resolved
keep-ui/utils/hooks/useProviderLogs.ts Outdated Show resolved Hide resolved
keep-ui/app/(keep)/providers/provider-logs.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@Kiryous Kiryous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG!

@shahargl shahargl merged commit baaf259 into main Dec 23, 2024
12 checks passed
@shahargl shahargl deleted the feature/grafana-legacy branch December 23, 2024 16:40
skynetigor pushed a commit that referenced this pull request Dec 23, 2024
Signed-off-by: Shahar Glazner <[email protected]>
Co-authored-by: Kirill Chernakov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new feature Provider Providers related issues size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: add grafana legacy alerting support
2 participants