feat: Add infra for cleaning up providers when deleted #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
Ihor Panasiuk seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
talboren
reviewed
Dec 18, 2024
keep/providers/providers_service.py
Outdated
| ) | ||
| except Exception as exc: | ||
| logger.exception(msg="Failed to clean up provider", | ||
| extra={ "error_msg": str(exc) }) |
There was a problem hiding this comment.
Nice PR! actually logger.exception already logs the exception itself alone so no need for that extra param!
dosubot
bot
added
size:M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #392
📑 Description
Added base functionality for cleaning up provider leftovers when it's deleted in Keep.
Now base provider has clean_up function that each inheritor can override in order to implement its own clean up logic. The function is called during provider deletion.
Add cleaning up webhooks for PagerDuty provider.
✅ Checks
ℹ Additional Information