Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): memory consumption and performance improvements #2908

Merged
merged 18 commits into from
Dec 27, 2024
Merged

feat(api): memory consumption and performance improvements #2908

merged 18 commits into from
Dec 27, 2024

Conversation

shahargl
Copy link
Member

close #2907

@vercel Vercel
Copy link

vercel bot commented Dec 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2024 8:18am

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. API API related issues Feature A new feature labels Dec 26, 2024
talboren
talboren reviewed Dec 26, 2024
View reviewed changes
keep/api/routes/alerts.py Outdated Show resolved Hide resolved
talboren
talboren reviewed Dec 26, 2024
View reviewed changes
keep/api/routes/alerts.py Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 26.31579% with 70 lines in your changes missing coverage. Please review.

Project coverage is 31.16%. Comparing base (6adf5bc) to head (e24586a).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
keep/workflowmanager/workflowscheduler.py 15.78% 64 Missing ⚠️
keep/api/logging.py 25.00% 3 Missing ⚠️
keep/workflowmanager/workflowmanager.py 50.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2908       +/-   ##
===========================================
- Coverage   43.63%   31.16%   -12.48%     
===========================================
  Files         162       70       -92     
  Lines       15789     7880     -7909     
===========================================
- Hits         6890     2456     -4434     
+ Misses       8899     5424     -3475

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shahargl and others added 4 commits December 26, 2024 13:54
@shahargl
feat: test
49fe34a
@shahargl @talboren
Update keep/workflowmanager/workflowscheduler.py
01958c8 
Co-authored-by: Tal <[email protected]>
Signed-off-by: Shahar Glazner <[email protected]>
@shahargl @talboren
Update keep/api/routes/alerts.py
b6ae552 
Co-authored-by: Tal <[email protected]>
Signed-off-by: Shahar Glazner <[email protected]>
@shahargl @talboren
Update keep/api/routes/alerts.py
a443838 
Co-authored-by: Tal <[email protected]>
Signed-off-by: Shahar Glazner <[email protected]>
@talboren talboren self-requested a review December 26, 2024 13:39
talboren
talboren previously approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 26, 2024
@talboren talboren mentioned this pull request Dec 26, 2024
Merged
@shahargl shahargl requested a review from talboren December 27, 2024 07:50
@shahargl shahargl merged commit 5c4ab0f into main Dec 27, 2024
11 checks passed
@shahargl shahargl deleted the feature/test branch December 27, 2024 08:31
@shahargl shahargl restored the feature/test branch December 30, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talboren talboren talboren approved these changes

Assignees
No one assigned
Labels
API API related issues Feature A new feature lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Better memory consumption and performance improvements
2 participants
@shahargl @talboren