Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hashicorp): Incorrect work with json in vault code #2917

Merged
merged 4 commits into from
Dec 30, 2024

Conversation

00041275
Copy link
Contributor

@00041275 00041275 commented Dec 27, 2024

Incorrect work with json. The json logic for secret_value should be similar to that of secret manager

This problem not have issue .

✅ Checks

  • My pull request adheres to the code style of this project
  • I have updated the documentation as required

After making the change, my keephq, which stores secrets in vault, began to work well

close #2927

Incorrect work with json. The json logic for secret_value should be similar to that of secret manager

Signed-off-by: Adilbek Kangerey <[email protected]>
Copy link

vercel bot commented Dec 27, 2024

@00041275 is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 27, 2024
@CLAassistant
Copy link

CLAassistant commented Dec 27, 2024

CLA assistant check
All committers have signed the CLA.

@dosubot dosubot bot added the Bug Something isn't working label Dec 27, 2024
@talboren
Copy link
Member

@00041275 thank you for this PR! can you explain what's not working? maybe you can create an issue for that?

@talboren
Copy link
Member

@00041275 ping :)

@00041275
Copy link
Contributor Author

of the Team first ne

sorry for waiting.
The fact is that when creating the provider, the script vault received json, but in the case of creating the API it was just a string. This broke the entire keephq initialization. I couldn't understand the reason. As a result, having studied similar implementations on Google, Amazon realized that it is impossible to convert data into json unambiguously when recording. That's the whole point why i rewrite row with json.loads.

@talboren talboren changed the title Incorrect work with json in hashicorp vault script fix(hashicorp): Incorrect work with json in vault code Dec 30, 2024
Copy link

vercel bot commented Dec 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 9:31am

@talboren
Copy link
Member

@00041275 if I understand correctly, you are referring to API key? Have you had a chance to test your fix? is it working properly now? would love to chat more in our Slack if you're not in it already

@00041275
Copy link
Contributor Author

@00041275 if I understand correctly, you are referring to API key? Have you had a chance to test your fix? is it working properly now? would love to chat more in our Slack if you're not in it already

Yes, that's right, this is an API key. Of course, everything works for me with the change. I'm not on Slack.

Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 30, 2024
@talboren talboren enabled auto-merge (squash) December 30, 2024 09:29
@talboren
Copy link
Member

@00041275 if I understand correctly, you are referring to API key? Have you had a chance to test your fix? is it working properly now? would love to chat more in our Slack if you're not in it already

Yes, that's right, this is an API key. Of course, everything works for me with the change. I'm not on Slack.

Would love for you to join @00041275 :) LGTM'd and merging as soon as workflows pass!

@talboren talboren merged commit 7a34226 into keephq:main Dec 30, 2024
9 of 10 checks passed
Copy link
Contributor

🔥 Fantastic work @00041275! Your very first PR to keep has been merged! 🎉🥳

You've just taken your first step into open-source, and we couldn't be happier to have you onboard. 🙌
If you're feeling adventurous, why not dive into another issue and keep contributing? The community would love to see more from you! 🚀

For any support, feel free to reach out on the community: https://slack.keephq.dev. Happy coding! 👩‍💻👨‍💻

@00041275 00041275 deleted the patch-1 branch December 30, 2024 09:36
@00041275
Copy link
Contributor Author

ЛГТМ!

Thanks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Hashicorp doesn't work well with non-json secrets
3 participants