-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hashicorp): Incorrect work with json in vault code #2917
Conversation
Incorrect work with json. The json logic for secret_value should be similar to that of secret manager Signed-off-by: Adilbek Kangerey <[email protected]>
@00041275 is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
@00041275 thank you for this PR! can you explain what's not working? maybe you can create an issue for that? |
@00041275 ping :) |
sorry for waiting. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Yes, that's right, this is an API key. Of course, everything works for me with the change. I'm not on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Would love for you to join @00041275 :) LGTM'd and merging as soon as workflows pass! |
🔥 Fantastic work @00041275! Your very first PR to keep has been merged! 🎉🥳 You've just taken your first step into open-source, and we couldn't be happier to have you onboard. 🙌 For any support, feel free to reach out on the community: https://slack.keephq.dev. Happy coding! 👩💻👨💻 |
Thanks) |
Incorrect work with json. The json logic for secret_value should be similar to that of secret manager
This problem not have issue .
✅ Checks
After making the change, my keephq, which stores secrets in vault, began to work well
close #2927