Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mapping): when using AND in matcher #2919

Merged
merged 3 commits into from
Dec 29, 2024
Merged

fix(mapping): when using AND in matcher #2919

merged 3 commits into from
Dec 29, 2024

Conversation

talboren
Copy link
Member

No description provided.

@talboren talboren linked an issue Dec 29, 2024 that may be closed by this pull request
[🐛 Bug]: mapping issue with && #2918
Closed
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 29, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 29, 2024 11:02am

@dosubot dosubot bot added the Bug Something isn't working label Dec 29, 2024
@talboren talboren enabled auto-merge (squash) December 29, 2024 10:52
shahargl
shahargl approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 29, 2024
@talboren talboren merged commit 3e3a0e6 into main Dec 29, 2024
11 checks passed
@talboren talboren deleted the 2918-bug-mapping-issue-with branch December 29, 2024 11:02
@codecov Codecov
Copy link

codecov bot commented Dec 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.24%. Comparing base (6adf5bc) to head (a57b61d).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/bl/enrichments_bl.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2919      +/-   ##
==========================================
- Coverage   43.63%   43.24%   -0.40%     
==========================================
  Files         162      167       +5     
  Lines       15789    16478     +689     
==========================================
+ Hits         6890     7126     +236     
- Misses       8899     9352     +453

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahargl shahargl shahargl approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: mapping issue with &&
2 participants
@talboren @shahargl