Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add soft-delete for incidents through the status #2922

Merged
merged 3 commits into from
Dec 30, 2024
Merged

feat: Add soft-delete for incidents through the status #2922

merged 3 commits into from
Dec 30, 2024

Conversation

VladimirFilonov
Copy link
Contributor

Closes #2909

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@vercel Vercel
Copy link

vercel bot commented Dec 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Dec 29, 2024 5:51pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Feature A new feature labels Dec 29, 2024
@VladimirFilonov VladimirFilonov force-pushed the feature/2909-see-deletedresolved-incidents branch from 5685373 to d9167c9 Compare December 29, 2024 10:45
talboren
talboren reviewed Dec 29, 2024
View reviewed changes
keep/api/models/alert.py Outdated Show resolved Hide resolved
talboren
talboren reviewed Dec 29, 2024
View reviewed changes
keep/api/core/db.py Outdated Show resolved Hide resolved
talboren
talboren requested changes Dec 29, 2024
View reviewed changes
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few minor comments

@VladimirFilonov VladimirFilonov force-pushed the feature/2909-see-deletedresolved-incidents branch from d9167c9 to 97aa93a Compare December 29, 2024 17:51
talboren
talboren approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 29, 2024
@VladimirFilonov VladimirFilonov merged commit 0dc943f into main Dec 30, 2024
12 checks passed
@VladimirFilonov VladimirFilonov deleted the feature/2909-see-deletedresolved-incidents branch December 30, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talboren talboren talboren approved these changes

Assignees
No one assigned
Labels
Feature A new feature lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: See deleted/resolved incidents
2 participants
@VladimirFilonov @talboren