Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: redirect on 401 #2923

Merged
merged 9 commits into from
Dec 29, 2024
Merged

fix: redirect on 401 #2923

merged 9 commits into from
Dec 29, 2024

Conversation

Kiryous
Copy link
Contributor

@Kiryous Kiryous commented Dec 29, 2024 •
edited
Loading

Closes #2584

📑 Description

  1. Sign out user if the API returned 401 on client
  2. If user is authenticated, redirect to callbackUrl if it present
  3. Polish SingInForm design
Screenshot 2024-12-29 at 17 04 50
  1. Use common layout for initial state
Screenshot 2024-12-29 at 17 49 05

@vercel Vercel
Copy link

vercel bot commented Dec 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 29, 2024 2:35pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. API API related issues UI User interface related issues labels Dec 29, 2024
@Kiryous Kiryous changed the title Fix/2584 expired jwt redirect fix: redirect on 401 Dec 29, 2024
talboren
talboren approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 29, 2024
@Kiryous Kiryous merged commit a04c6b1 into main Dec 29, 2024
10 checks passed
@Kiryous Kiryous deleted the fix/2584-expired-jwt-redirect branch December 29, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talboren talboren talboren approved these changes

@shahargl shahargl Awaiting requested review from shahargl

@VladimirFilonov VladimirFilonov Awaiting requested review from VladimirFilonov

Assignees
No one assigned
Labels
API API related issues lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. UI User interface related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: add application-wide 403/401 handling
2 participants
@Kiryous @talboren